From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: kuznet@ms2.inr.ac.ru
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)
Date: Fri, 03 Nov 2000 16:29:22 -0500 [thread overview]
Message-ID: <3A032E32.39E7B151@mandrakesoft.com> (raw)
In-Reply-To: <200011031937.WAA10753@ms2.inr.ac.ru>
kuznet@ms2.inr.ac.ru wrote:
>
> Hello!
>
> > that does hardware register access without protecting against interrupts
> > or checking if the interface is up.
>
> This issue is not that issue. It is separate issue and in fact
> it is private problem of driver and its author, what is safe,
> what is not safe.
>
> F.e. I see no cathastrophe even if MII registers are accessed without
> any protections. Diag utilities do this from user space. 8)8)
It depends on the hardware... For the ioctl-only case, you are
correct. rtnl_lock protects us there. But when the timer and ioctl
both call mdio_xxx, you need SMP protection, otherwise you corrupt the
multi-step MDIO read/write found in many drivers.
IMNSHO the timer routines found in net drivers should all be converted
to kernel threads. There are too many limitations placed on you by
timers.
> > de4x5 is probably also buggy in regard to this.
>
> de4x5 is hopeless. I added nice comment in softnet to it.
> Unfortunately it was lost. 8)
>
> Andi, neither you nor me nor Alan nor anyone are able to audit
> all this unnevessarily overcomplicated code. It was buggy, is buggy
> and will be buggy. It is inavoidable, as soon as you have hundreds
> of drivers.
de4x5 is becoming EISA-only in 2.5.x too, since its PCI support is
duplicated now in tulip driver.
Jeff
--
Jeff Garzik | Dinner is ready when
Building 1024 | the smoke alarm goes off.
MandrakeSoft | -/usr/games/fortune
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-03 21:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20001103202911.A2979@gruyere.muc.suse.de>
2000-11-03 19:37 ` Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10) kuznet
2000-11-03 21:29 ` Jeff Garzik [this message]
2000-11-04 19:41 ` kuznet
2000-11-06 9:10 ` Jeff Garzik
2000-11-06 17:45 ` kuznet
2000-11-08 17:48 ` tulip vs. de4x5 (was Re: Linux 2.4 Status / TODO page ...) Jim Schutt
2000-11-03 22:01 ` Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10) Bill Wendling
2000-11-03 22:30 ` Jeff Garzik
2000-11-03 23:41 ` Andi Kleen
2000-11-03 23:57 ` Jeff Garzik
2000-11-04 9:04 ` Andi Kleen
2001-01-07 1:48 ` David C. Davies
2001-01-07 2:14 ` David C. Davies
2000-11-04 0:19 ` Alan Cox
2000-11-03 15:09 tytso
2000-11-03 15:53 ` Alan Cox
2000-11-03 16:55 ` Andi Kleen
2000-11-03 19:03 ` kuznet
2000-11-03 21:03 ` David Ford
2000-11-03 21:10 ` Jeff Garzik
2000-11-03 21:51 ` David Ford
2000-11-04 1:27 ` Jeff Garzik
2000-11-04 0:14 ` Alan Cox
2000-11-04 1:24 ` Jeff Garzik
2000-11-04 2:37 ` David Ford
2000-11-07 20:21 ` tytso
2000-11-07 19:23 ` Jeff Garzik
2000-11-03 21:37 ` Jeff Garzik
2000-11-06 19:28 ` Paul Gortmaker
2000-11-07 20:17 ` tytso
2000-11-07 19:21 ` Jeff Garzik
2000-11-03 16:09 ` Philipp Rumpf
2000-11-03 22:20 ` Jeff Garzik
2000-11-04 2:32 ` David Ford
2000-11-04 13:12 ` Stephen C. Tweedie
2000-11-07 20:40 ` tytso
2000-11-04 1:10 ` James Simmons
2000-11-04 1:38 ` Keith Owens
2000-11-11 22:47 ` tytso
2000-11-04 10:43 ` Keith Owens
2000-11-04 20:34 ` Russell King
2000-11-05 23:15 ` David Woodhouse
2000-11-06 0:47 ` Keith Owens
2000-11-06 0:54 ` David Woodhouse
2000-11-07 20:36 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A032E32.39E7B151@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=ak@suse.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).