linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ryan <ryan@netidea.com>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: Kernel 2.4.0test10 crash (RAID+SMP)
Date: Sun, 05 Nov 2000 16:09:29 -0800	[thread overview]
Message-ID: <3A05F6B9.6A6BE9C7@netidea.com> (raw)
In-Reply-To: <1459.973469046@kao2.melbourne.sgi.com> <3A060BE5.8877F477@netidea.com> <14854.8617.282831.205647@notabene.cse.unsw.edu.au>

> It looks like an interupt is happening while another interrupt is
> happening, which should be impossible... but it isn't.

Dont you love SMP? ;-)

> 
> raid1.c:end_sync_write calls raid1_free_buff which calls
> spin_lock_irq()/spin_unlock_irq(), which unmasks interrupts.  but
> end_sync_write is called from interupt context.  This is bad.
> 
> Try:
[patch goes here]
> 

This infact fixes the problem completely.  You probably already
suspected it did, but for verification it works like a charm.  Inclusion
into 2.4.0test11/whatever would probably be a Good Thing.

-ryan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2000-11-06  8:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-05 21:08 Kernel 2.4.0test10 crash (RAID+SMP) ryan
2000-11-06  0:04 ` Keith Owens
2000-11-06  1:39   ` ryan
2000-11-06  3:12     ` Neil Brown
2000-11-06  0:09       ` ryan [this message]
2000-11-06  9:00       ` Jeff Garzik
2000-11-06  9:40         ` Andre Hedrick
2000-11-06 22:19         ` Neil Brown
2000-11-06 11:51 ` Jason Straight
2000-11-07  0:02 Ion Badulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A05F6B9.6A6BE9C7@netidea.com \
    --to=ryan@netidea.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).