linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: braun@itwm.fhg.de
To: linux-kernel@vger.kernel.org
Cc: jhartmann@valinux.com
Subject: Small fix for via agpgart in 2.2.19pre13
Date: Sun, 25 Feb 2001 13:57:44 +0100	[thread overview]
Message-ID: <3A990148.4F113D8@itwm.uni-kl.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

Hello all,

the following fix from linux-2.4.2 is not yet in 2.2.19pre.
The agpgart module can not be properly unloaded and 
reloaded without it.
(see http://uwsg.indiana.edu/hypermail/linux/kernel/0101.2/1273.html
for details)

Martin Braun

[-- Attachment #2: linux-2.2.19pre-agpgart.diff --]
[-- Type: text/plain, Size: 559 bytes --]

--- linux-2.2.19-pre13/drivers/char/agp/agpgart_be.c	Sat Feb 24 13:29:30 2001
+++ linux/drivers/char/agp/agpgart_be.c	Sun Feb 25 13:32:16 2001
@@ -1304,9 +1304,11 @@
 	aper_size_info_8 *previous_size;
 
 	previous_size = A_SIZE_8(agp_bridge.previous_size);
-	pci_write_config_dword(agp_bridge.dev, VIA_ATTBASE, 0);
 	pci_write_config_byte(agp_bridge.dev, VIA_APSIZE,
 			      previous_size->size_value);
+	/* Do not disable by writing 0 to VIA_ATTBASE, it screws things up
+	 * during reinitialization.
+	 */
 }
 
 static void via_tlbflush(agp_memory * mem)

                 reply	other threads:[~2001-02-25 13:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A990148.4F113D8@itwm.uni-kl.de \
    --to=braun@itwm.fhg.de \
    --cc=jhartmann@valinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: Small fix for via agpgart in 2.2.19pre13' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).