linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: pat@isis.co.za, linux-kernel@vger.kernel.org, Alan@redhat.com
Subject: Re: PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On)
Date: Mon, 26 Feb 2001 15:10:52 -0500	[thread overview]
Message-ID: <3A9AB84C.A17D20AE@mandrakesoft.com> (raw)
In-Reply-To: <3A9A30C7.3C62E34@colorfullife.com>

Manfred Spraul wrote:
> 
> I think I found the bug:
> 
> Someone (Jeff?) removed the line
> 
>         tp->advertising[phy_idx++] = reg4;
> 
> from tulip/tulip_core.c
> 
> pnic_check_duplex uses that variable :-(
> 
> There are 2 workarounds:
> 
> * change pnic_check_duplex:
> s/tp->advertising[0]/tp->mii_advertise/g
> 
> * remove the new mii_advertise variable and replace it with
> 'tp->advertising[i]'.

mii_advertise is what MII is currently advertising on the current
media.  tp->advertising is per-phy, on the other hand.

Pat, Manfred, in pnic_check_duplex, make this change:
> -        negotiated = mii_reg5 & tp->advertising[0];
> +        negotiated = mii_reg5 & tulip_mdio_read(dev, tp->phys[0], 4);

and let me know how it goes.  I'm tempted to just remove
tp->advertising[] altogether.

	Jeff


-- 
Jeff Garzik       | "You see, in this world there's two kinds of
Building 1024     |  people, my friend: Those with loaded guns
MandrakeSoft      |  and those who dig. You dig."  --Blondie

  reply	other threads:[~2001-02-26 20:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-26 10:32 PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On) Manfred Spraul
2001-02-26 20:10 ` Jeff Garzik [this message]
2001-02-26 20:58   ` Manfred Spraul
2001-03-02 21:15     ` Jeff Garzik
2001-03-02 21:03       ` I/O problem with sustained writes Collectively Unconscious
2001-03-02 23:57         ` Andrew Morton
2001-03-02 22:20       ` PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On) Manfred Spraul
2001-03-02 22:48         ` Donald Becker
2001-02-27  6:16   ` Pat Verner
  -- strict thread matches above, loose matches on Subject: below --
2001-02-27  6:31 Pat Verner
2001-02-26  7:45 Pat Verner
2001-02-22  7:56 PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On) NIC Pat Verner
2001-02-22 10:42 ` PROBLEM: Network hanging - Tulip driver with Netgear (Lite-On) Alan Cox
2001-02-22 20:12   ` Jeff Garzik
2001-02-22 12:42 ` Pat Verner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A9AB84C.A17D20AE@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=Alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=pat@isis.co.za \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).