From: george anzinger <george@mvista.com>
To: Hubertus Franke <frankeh@us.ibm.com>
Cc: mingo@elte.hu, Linux Kernel List <linux-kernel@vger.kernel.org>,
lse-tech@lists.sourceforge.net
Subject: Re: [Lse-tech] Bug in sys_sched_yield
Date: Thu, 12 Apr 2001 09:08:49 -0700 [thread overview]
Message-ID: <3AD5D311.5BFE39A6@mvista.com> (raw)
In-Reply-To: <OFC3243AAE.31877E4B-ON85256A2B.006AE9C3@pok.ibm.com>
Hubertus Franke wrote:
>
> In the recent optimizations to sys_sched_yield a bug was introduced.
> In the current implementation of sys_sched_yield()
> the aligned_data and idle_tasks are indexed by logical cpu-#.
>
> They should however be indexed by physical cpu-#.
> Since logical==physical on the x86 platform, it doesn't matter there,
> for other platforms where this is not true it will matter.
> Below is the fix.
>
Uh... I do know about this map, but I wonder if it is at all needed.
What is the real difference between a logical cpu and the physical one.
Or is this only interesting if the machine is not Smp, i.e. all the cpus
are not the same? It just seems to me that introducing an additional
mapping just slows things down and, if all the cpus are the same, does
not really do anything. Of course, I am assuming that ALL usage would
be to the logical :)
George
next prev parent reply other threads:[~2001-04-12 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-11 19:31 Bug in sys_sched_yield Hubertus Franke
2001-04-11 20:12 ` Andrea Arcangeli
2001-04-12 16:08 ` george anzinger [this message]
2001-04-12 16:49 ` [Lse-tech] " Walt Drummond
2001-04-12 17:31 ` george anzinger
2001-04-16 16:03 ` Walt Drummond
[not found] <OF33FEDED1.EDF6D260-ON85256A2D.006D99DE@pok.ibm.com>
2001-04-15 17:23 ` Kanoj Sarcar
2001-04-16 16:00 ` Walt Drummond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AD5D311.5BFE39A6@mvista.com \
--to=george@mvista.com \
--cc=frankeh@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).