linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artur Petrosyan <arthur.petrosyan@synopsys.com>
To: John Stultz <john.stultz@linaro.org>,
	Artur Petrosyan <arthur.petrosyan@synopsys.com>
Cc: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
	lkml <linux-kernel@vger.kernel.org>,
	John Youn <John.Youn@synopsys.com>,
	"Felipe Balbi" <felipe.balbi@linux.intel.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature
Date: Tue, 25 Sep 2018 10:04:07 +0000	[thread overview]
Message-ID: <3AD91E696667BF4BA728303C178E8A63532AB5E5@am04wembxb.internal.synopsys.com> (raw)
In-Reply-To: CALAqxLXy0YXNLwFQEUZxSsjFKC9boVcGkt+50XwmVfwKCcqsEw@mail.gmail.com

Hi John,

On 9/24/2018 22:52, John Stultz wrote:
> On Sun, Sep 23, 2018 at 10:57 PM, Artur Petrosyan
> <arthur.petrosyan@synopsys.com> wrote:
>> Hi John,
>>
>> On 9/21/2018 05:05, John Stultz wrote:
>>> On Thu, Sep 20, 2018 at 7:17 AM, Artur Petrosyan
>>> <Arthur.Petrosyan@synopsys.com> wrote:
>>>> On 5/23/2018 01:57, John Stultz wrote:
>>>>> Its done automatically, when the OTG cable is detected it the host
>>>>> ports are disabled and when the OTG port is empty the host ports are
>>>>> enabled.
>>>>>
>>>>> Let me know if you need anything else!
>>>>>
>>>>
>>>> Please apply the patch set with this cover letter "[PATCH 0/3] usb:
>>>> dwc2: Fix hibernation for switching between host and device modes."
>>>
>>> Sorry, can you send the patches to me, or point me to a git tree? I'm
>>> not seeing that thread in my mailbox or on google.
>>>
>>>> Enable the power down on his devices. Let me know if you still see any
>>>> issue. If there is no issue, please provide Tested-by tag.
>>>
>>> Would be happy to test it, thought I'm traveling tomorrow, so I may
>>> not be able to validate till monday.
>>>
>>> thanks
>>> -john
>>>
>>
>> You can find the patch set following to this link.
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__marc.info_-3Fl-3Dlinux-2Dusb-26m-3D153745139408236-26w-3D2&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=dfaz_WctFBdFgywM2g9w0XVhgOdAS4gIsj9o23RnyvY&s=_Nz3ephAop_nqrfcICii4OgMkV14Mi4yaKk8-qPqdis&e=
> 
> I applied those three patches, and it seems to work ok.
> 
> Just to be clear, was there anything else I was needing to do while testing it?
> 
> Otherwise,
> Tested-by: John Stultz <john.stultz@linaro.org>   #On HiKey
> 
> thanks
> -john
> 

Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey 
regression caused by power_down feature"
https://marc.info/?l=linux-usb&m=152669095513248&w=2

the power_down is disabled setting "p->power_down = false;" in 
"dwc2_set_his_params" function.

Could you please clarify that the testes done for those 3 patches were 
done enabling "p->power_down = true;" in "dwc2_set_his_params" function.

Regards,
Artur




  reply	other threads:[~2018-09-25 10:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-19  0:49 [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature John Stultz
2018-05-21  8:45 ` Minas Harutyunyan
2018-05-21 19:40   ` John Stultz
2018-05-22 14:24     ` Minas Harutyunyan
2018-05-22 21:57       ` John Stultz
2018-09-20 14:17         ` Artur Petrosyan
2018-09-21  1:05           ` John Stultz
2018-09-24  5:57             ` Artur Petrosyan
2018-09-24 18:51               ` John Stultz
2018-09-25 10:04                 ` Artur Petrosyan [this message]
2018-09-25 17:59                   ` John Stultz
2018-09-26  6:02                     ` Artur Petrosyan
     [not found]                       ` <CALAqxLWOBFO_CjfBFNwbC+qNjtK=TgYrPusb4r5-dThBD5bVnw@mail.gmail.com>
2018-10-01  6:56                         ` Artur Petrosyan
2018-09-27 12:33                     ` Artur Petrosyan
2018-09-28 18:32                       ` John Stultz
2018-10-01  7:06                         ` Artur Petrosyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AD91E696667BF4BA728303C178E8A63532AB5E5@am04wembxb.internal.synopsys.com \
    --to=arthur.petrosyan@synopsys.com \
    --cc=John.Youn@synopsys.com \
    --cc=Minas.Harutyunyan@synopsys.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).