From: Bryan Rittmeyer <bryan@ixiacom.com>
To: Herbert Rosmanith <herp@wildsau.idv-edu.uni-linz.ac.at>
Cc: linux-kernel@vger.kernel.org
Subject: Re: arp.c duplicate assignment of skb->dev ("cosmetic")
Date: Thu, 30 Aug 2001 11:13:56 -0700 [thread overview]
Message-ID: <3B8E8264.8090700@ixiacom.com> (raw)
In-Reply-To: <200108301718.f7UHIWq19376@wildsau.idv-edu.uni-linz.ac.at>
Herbert Rosmanith wrote:
> hi,
>
> this is rather cosmetical than functional, but in arp.c,
> in arp_send(), on line 489
>
> skb->dev=dev;
>
> is assigned. in line 563, still in the same routine, it is
> assigned again without skb or skb->dev being changed. so I guess
> this second assignment is not neccessary. I can't see where
> skb->dev is changed within the 80 lines. so, we could remove
> the second assignment.
Hi Herbert,
I also noticed this dupe a couple days ago and pointed it out to
the lkml and net code maintainers. Alexey Kuznetsov has
agreed, saying:
"Apparently, this is right. This happened ages ago when eliminating
second argument dev_queue_xmit()."
I assume a fix will be in the next major release.
Regards,
Bryan
--
Bryan Rittmeyer
mailto:bryan@ixiacom.com
next prev parent reply other threads:[~2001-08-30 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-30 17:18 arp.c duplicate assignment of skb->dev ("cosmetic") Herbert Rosmanith
2001-08-30 18:13 ` Bryan Rittmeyer [this message]
2001-08-30 20:03 ` Herbert Rosmanith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B8E8264.8090700@ixiacom.com \
--to=bryan@ixiacom.com \
--cc=herp@wildsau.idv-edu.uni-linz.ac.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).