From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756AbdK3Nga (ORCPT ); Thu, 30 Nov 2017 08:36:30 -0500 Received: from netsrv01.beckhoff.com ([62.159.14.10]:55686 "EHLO Netsrv01.beckhoff.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbdK3Ng1 (ORCPT ); Thu, 30 Nov 2017 08:36:27 -0500 From: =?utf-8?B?UGF0cmljayBCcsO8bm4=?= To: Philippe Ombredanne , Greg Kroah-Hartman CC: linux-kernel-dev , Alessandro Zummo , Alexandre Belloni , Rob Herring , Mark Rutland , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Fabio Estevam , Juergen Borleis , Noel Vellemans , Shawn Guo , Sascha Hauer , Russell King , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: RE: [PATCH] rtc: add mxc driver for i.MX53 Thread-Topic: [PATCH] rtc: add mxc driver for i.MX53 Thread-Index: AQHTaBwKpxDvSsc/uEq6cJ4tWZLD0aMr3PUAgACplICAAGG3gA== Date: Thu, 30 Nov 2017 13:36:22 +0000 Message-ID: <3BB206AB2B1BD448954845CE6FF69A8E01CB531330@NT-Mail07.beckhoff.com> References: <20171128073927.12035-1-linux-kernel-dev@beckhoff.com> <20171129221114.GV21126@piout.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.64.168] x-olx-disclaimer: Done Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAUDaZCx025156 >From: Philippe Ombredanne [mailto:pombredanne@nexb.com] >Sent: Donnerstag, 30. November 2017 09:18 >> >>> +/* >>> + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights >Reserved. >>> + */ >>> + >>> +/* >>> + * The code contained herein is licensed under the GNU General Public >>> + * License. You may obtain a copy of the GNU General Public License >>> + * Version 2 or later at the following locations: >>> + * >>> + * http://www.opensource.org/licenses/gpl-license.html >>> + * http://www.gnu.org/copyleft/gpl.html >>> + */ > >Exactly! >And while you are it , you could replace the boilerplate license text >with the SPDX id. >-- How would a perfect header look like? Looking at : git show b24413180f5600bcb3bb70fbed5cf186b60864bd -- drivers/ and: git grep SPDX -- Documentation/ it could be: +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights + */ or: +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights + */ Personally I would prefer: +/* + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights + * + * SPDX-License-Identifier: GPL-2.0 + */ So, is there any guideline? To be clear: I don't want to waste anyone's time on this. But as SPDX was intended for automation, I think it might be good to try having some common pattern here. I don't want to start a discussion, so in case there is no guideline I will just take the /* SPDX */ in firstline version. Regards, Patrick Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075