From: Andrew Morton <akpm@zip.com.au>
To: Stephen Tweedie <sct@redhat.com>
Cc: "Steven N. Hirsch" <shirsch@adelphia.net>,
lkml <linux-kernel@vger.kernel.org>,
"ext3-users@redhat.com" <ext3-users@redhat.com>
Subject: Re: ext3-0.9.15 against linux-2.4.14
Date: Wed, 07 Nov 2001 09:59:50 -0800 [thread overview]
Message-ID: <3BE97696.B7B28810@zip.com.au> (raw)
In-Reply-To: <3BE7AB6C.97749631@zip.com.au> <Pine.LNX.4.33.0111061305540.8366-100000@atx.fast.net>, <Pine.LNX.4.33.0111061305540.8366-100000@atx.fast.net>; from shirsch@adelphia.net on Tue, Nov 06, 2001 at 01:09:42PM -0500 <20011107003131.D7290@redhat.com>
Stephen Tweedie wrote:
>
> Andrew, the code
>
> if (page->buffers) {
> /*
> * Anonymous buffercache page left behind by
> * truncate.
> */
> printk(__FUNCTION__ ": page has buffers!\n");
> goto preserve;
> }
>
> is going to end up preserving the pte forever and shouting to syslog
> every time the VM walks over the pte in question. I'd be just as
> happy dropping these ptes on the floor when we find them, as they are
> clearly of no use to anybody at this point.
>
Yes, perhaps we could do something smarter - I wasn't even sure it
was possible to hit any more (still waiting to hear back from
Steve Hirsch!)
The idea is that in this rare case, shrink_cache() will at
some later time revisit the page and again try to remove its
buffers, and will succeed. It's still on the LRU.
We definitely need to kill the printk(), but I really want
to get to test this code path locally.
-
prev parent reply other threads:[~2001-11-07 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-06 9:20 ext3-0.9.15 against linux-2.4.14 Andrew Morton
2001-11-06 9:42 ` Alan Cox
2001-11-06 18:09 ` Steven N. Hirsch
2001-11-06 18:49 ` Andrew Morton
2001-11-07 0:31 ` Stephen Tweedie
2001-11-07 17:59 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BE97696.B7B28810@zip.com.au \
--to=akpm@zip.com.au \
--cc=ext3-users@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=shirsch@adelphia.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).