From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Helge Hafting <helgehaf@aitel.hist.no>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Changelogs on kernel.org
Date: Mon, 13 May 2002 15:00:35 -0400 [thread overview]
Message-ID: <3CE00D53.8000503@mandrakesoft.com> (raw)
In-Reply-To: <20020512010709.7a973fac.spyro@armlinux.org> <abmi0f$ugh$1@penguin.transmeta.com> <873cwx2hi4.fsf@CERT.Uni-Stuttgart.DE> <abn6q9$umv$1@penguin.transmeta.com> <3CDF4AAE.1020605@mandrakesoft.com> <3CDF9760.FF53DDF7@aitel.hist.no>
Helge Hafting wrote:
>Jeff Garzik wrote:
>
>>(speaking more to the crowd...)
>>Changeset comments need to be written as if they stand alone, without
>>any other context -- including the author. A reader should not need to
>>know that (for examples) James Simmons hacks on fbdev stuff.
>>
>
>I think it is nice to have the names. A new kernel
>might break something, It is then nice to know
>where to send the bug report. (It is usually, but not
>necessarily the maintainer that did it.)
>
Having the name is fine -- I agree it should not be removed.
However, that was not the point of my message. The point is, each
changeset comment comes with -no context at all-. If the author of the
comment assumes that, by his name, we can figure out what a comment like
"minor fixes" mean, that author is making a mistake. Each cset comment
needs to tell exactly what the change is, and should not require
knowledge of the author's identity to determine what is in the changeset.
Jeff
next prev parent reply other threads:[~2002-05-13 19:02 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-12 0:07 Changelogs on kernel.org Ian Molton
2002-05-12 0:48 ` Diego Calleja
2002-05-12 1:09 ` john slee
2002-05-12 1:14 ` john slee
2002-05-12 5:05 ` Brian C. Huffman
2002-05-12 10:05 ` Johnny Mnemonic
2002-05-13 0:46 ` Rik van Riel
2002-05-13 11:52 ` Marcus Alanen
2002-05-13 12:09 ` Tomas Szepe
2002-05-13 13:08 ` Marcus Alanen
2002-05-13 14:08 ` Tomas Szepe
2002-05-13 14:45 ` Tomas Szepe
2002-05-13 14:06 ` Greg KH
2002-05-13 15:11 ` Tomas Szepe
2002-05-13 14:51 ` Greg KH
2002-05-13 15:58 ` Matthias Andree
2002-05-13 16:01 ` Freeze on 2.4.18 Pol
2002-05-13 15:21 ` Changelogs on kernel.org Matthias Andree
2002-05-13 22:05 ` Robinson Maureira Castillo
2002-05-13 23:41 ` Tomas Szepe
2002-05-14 8:44 ` Matthias Andree
2002-05-14 8:43 ` Matthias Andree
2002-05-14 9:23 ` Tomas Szepe
2002-05-13 11:58 ` Tomas Szepe
2002-05-13 12:39 ` Dave Gilbert (Home)
2002-05-13 13:01 ` Russell King
2002-05-13 13:27 ` Tomas Szepe
2002-05-13 13:42 ` Russell King
2002-05-13 15:12 ` Larry McVoy
2002-05-13 15:29 ` Tomas Szepe
2002-05-13 15:37 ` Larry McVoy
2002-05-12 9:14 ` Trever L. Adams
2002-05-12 20:06 ` Linus Torvalds
2002-05-12 20:20 ` Jeff Garzik
2002-05-12 20:31 ` Dr. David Alan Gilbert
2002-05-12 20:41 ` Arnaldo Carvalho de Melo
2002-05-13 20:57 ` Linus Torvalds
2002-05-14 0:29 ` Arnaldo Carvalho de Melo
2002-05-13 1:56 ` Linus Torvalds
2002-05-13 9:31 ` Matthias Andree
2002-05-13 8:52 ` Greg KH
2002-05-13 10:41 ` Matthias Andree
2002-05-13 10:12 ` Tomas Szepe
2002-05-13 10:17 ` Tomas Szepe
2002-05-13 13:00 ` Ian Molton
2002-05-12 20:31 ` Matthew D. Pitts
2002-05-12 20:35 ` Anton Altaparmakov
2002-05-12 21:04 ` HPFS and linux-2.4.18 Wojciech "Sas" Cieciwa
2002-05-12 21:17 ` Changelogs on kernel.org Florian Weimer
2002-05-12 21:42 ` Marcus Alanen
2002-05-12 22:12 ` Tomas Szepe
2002-05-13 10:32 ` Helge Hafting
2002-05-13 7:34 ` Kristian Peters
2002-05-12 21:51 ` Ian Molton
2002-05-12 21:47 ` Florian Weimer
2002-05-12 23:50 ` Sven.Riedel
2002-05-13 2:01 ` Linus Torvalds
2002-05-13 5:10 ` Jeff Garzik
2002-05-13 5:17 ` Larry McVoy
2002-05-13 10:37 ` Helge Hafting
2002-05-13 19:00 ` Jeff Garzik [this message]
2002-05-13 8:57 ` jw schultz
2002-05-13 8:06 ` Greg KH
[not found] <30386.1021456050@redhat.com>
2002-05-15 16:39 ` Linus Torvalds
2002-05-15 18:07 ` David Woodhouse
2002-05-15 19:20 ` Larry McVoy
2002-05-15 20:03 ` David Woodhouse
2002-05-15 20:08 ` Larry McVoy
2002-05-15 20:15 ` David Woodhouse
2002-05-15 20:34 ` Larry McVoy
2002-05-15 21:03 ` Kenneth Johansson
2002-05-15 22:30 ` Larry McVoy
2002-05-15 22:56 ` Kai Germaschewski
2002-05-15 22:59 ` Larry McVoy
2002-05-16 2:26 ` Horst von Brand
2002-05-16 7:02 ` Rusty Russell
2002-05-15 21:38 James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE00D53.8000503@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=helgehaf@aitel.hist.no \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).