From: Andrew Morton <akpm@digeo.com>
To: Rick Lindsley <ricklind@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] sard changes for 2.5.34
Date: Thu, 12 Sep 2002 12:42:21 -0700 [thread overview]
Message-ID: <3D80EE1D.34AF4FF2@digeo.com> (raw)
In-Reply-To: 200209120918.g8C9IND03853@eng4.beaverton.ibm.com
Rick Lindsley wrote:
>
> OK, that's a start. I think there was some work done on making
> kernel_stat percpu as well.
>
> Yes there's work on a couple of different fronts there. There is work
> to specifically make disk stats per cpu (actually, I have some 2.4
> patches already I could port), and there is a more general interface
> (statctr_t) which Dipankar Sarma (dipankar@in.ibm.com) is working on
> for 2.5 for stat counters in general which generalizes the per-cpu
> concept.
>
> Regardless of which route we go, can you suggest a good exercise to
> demonstrate the advantage of per-cpu counters? It seems intuitive to
> me, but I'm much more comfortable when I have numbers to back me up.
I don't think this is enough to justify a new subsystem like
statctr_t (struct statctr, please).
Looks like we can take the disk stats out of kernel_stat, move all
the vm-related things out of kernel_stat into struct page_state and
what's left of kernel_stat?
unsigned int per_cpu_user[NR_CPUS],
per_cpu_nice[NR_CPUS],
per_cpu_system[NR_CPUS];
unsigned int irqs[NR_CPUS][NR_IRQS];
And that's good, because "kernel statistics" was clearly too
broad a concept. The above is just one concept: interrupts and
scheduler things.
I'll pull the VM accounting out of there; when you have a
close-to-final patch for the disk stats we can give it a whizz
in the -mm patches and then get all the userspace tools working
nicely against that, OK?
I'm not sure that I want to add 14 more fields to /proc/meminfo.
So a new /proc/vmstat may appear. We would then have:
/proc/stat scheduler things
/proc/diskstat disk things
/proc/vmstat vm things
next prev parent reply other threads:[~2002-09-12 19:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-12 2:10 [RFC][PATCH] sard changes for 2.5.34 Rick Lindsley
2002-09-12 2:42 ` Andrew Morton
2002-09-12 2:50 ` Rik van Riel
2002-09-12 6:40 ` Rick Lindsley
2002-09-12 7:20 ` Andrew Morton
2002-09-12 9:18 ` Rick Lindsley
2002-09-12 10:01 ` Alexander Viro
2002-09-12 10:33 ` Rick Lindsley
2002-09-12 19:42 ` Andrew Morton [this message]
2002-09-12 20:38 ` Rik van Riel
2002-09-12 16:16 ` Rik van Riel
2002-09-12 16:48 ` Andrew Morton
2002-09-12 23:32 ` Denis Vlasenko
2002-09-12 18:49 ` Andrew Morton
2002-09-12 19:50 ` Rick Lindsley
2002-09-13 11:39 Dipankar Sarma
2002-09-14 18:57 Lev Makhlis
2002-09-18 17:54 ` Randy.Dunlap
2002-09-18 19:43 ` Lev Makhlis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D80EE1D.34AF4FF2@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).