From: Jeff Garzik <jgarzik@pobox.com>
To: Greg KH <greg@kroah.com>
Cc: Larry Kessler <kessler@us.ibm.com>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>,
cgl_discussion mailing list <cgl_discussion@osdl.org>,
evlog mailing list <evlog-developers@lists.sourceforge.net>,
Rusty Russell <rusty@rustcorp.com.au>,
Hien Nguyen <hien@us.ibm.com>,
James Keniston <kenistoj@us.ibm.com>,
Mike Sullivan <sullivam@us.ibm.com>
Subject: Re: [PATCH-RFC] README 1ST - New problem logging macros (2.5.38)
Date: Tue, 24 Sep 2002 01:28:27 -0400 [thread overview]
Message-ID: <3D8FF7FB.7020504@pobox.com> (raw)
In-Reply-To: 20020924051505.GA21499@kroah.com
Greg KH wrote:
>>The concept:
>>-----------
>>* Device Drivers use new macros to log "problems" when errors are
>> detected.
>
>
> Nice concept. But what's wrong with the existing method of logging when
> errors are detected? Can you give us some background as to what is
> lacking in the current stuff?
Bah, who needs define a problem when you have a sexy solution...
</sarcasm>
>>If event logging is configured....
>>
>>* During the build process
>> the static details (textual description, problem attribute names,
>> format specifiers for problem attributes, source file name, function
>> name and line number) associated with the problem() and introduce()
>> calls are stored in a .log section in the .o file.
>
>
> Nice.
indeed
>>(3) 'make templates' extracts this data from the disk_dummy.o file and
>> generates a formatting template in templates/disk_dummy/disk_dummy.t:
>>
>> facility "disk_dummy";
>> event_type 0x8ab218f4; /* file, message */
I don't see why we need a "make templates" at all in the kernel tarball.
This can be totally external to the kernel and still work fine.
>>(4) 'make templates_install' copies disk_dummy/disk_dummy.t to
>> /var/evlog/templates.
If they are compiled into the kernel and modules, this is not needed in
the kernel tarball either.
It should be straightforward to [re-]generate templates on boot, much
like module dependencies are [re-]computed on boot when necessary.
>>Notes:
>>-----
>>For the following 3 invocations, the first 2 work, the 3rd does not...
>>
>>problem(LOG_ALERT, "Disk on fire"); // OK
>>
>>#define DISK_ON_FIRE "Disk on fire"
>>problem(LOG_ALERT, DISK_ON_FIRE); // OK
>>
>>msg = "Disk on fire";
>>problem(LOG_ALERT, msg); // No good
>
>
> Why does this not work?
doh! I missed that. That "no good" example is in use in the kernel
today, implying that this new API reduces functionality...
Jeff
next prev parent reply other threads:[~2002-09-24 5:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-24 1:55 [PATCH-RFC] README 1ST - New problem logging macros (2.5.38) Larry Kessler
2002-09-24 2:40 ` Jeff Garzik
2002-09-24 5:55 ` Rusty Russell
2002-09-24 6:11 ` Jeff Garzik
2002-09-24 6:58 ` Rusty Russell
2002-09-24 5:15 ` Greg KH
2002-09-24 5:28 ` Jeff Garzik [this message]
2002-09-26 18:56 ` Larry Kessler
2002-09-26 19:38 ` Rik van Riel
2002-09-26 20:01 ` Larry Kessler
2002-09-26 18:41 ` Rob Landley
2002-09-24 5:58 ` Greg KH
2002-09-24 16:32 ` Patrick Mochel
2002-09-24 8:36 ` Andrey Savochkin
2002-09-24 4:49 [PATCH-RFC] " Larry Kessler
2002-09-24 12:58 ` Denis Vlasenko
2002-09-24 13:59 ` Gerhard Mack
2002-09-24 22:38 ` Thunder from the hill
2002-09-24 4:56 Jeff Garzik
2002-09-24 14:04 Randal, Phil
2002-09-24 14:15 ` Sven Koch
2002-09-26 15:43 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D8FF7FB.7020504@pobox.com \
--to=jgarzik@pobox.com \
--cc=cgl_discussion@osdl.org \
--cc=evlog-developers@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=hien@us.ibm.com \
--cc=kenistoj@us.ibm.com \
--cc=kessler@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sullivam@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).