From: Andrew Morton <akpm@digeo.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Chuck Lever <cel@citi.umich.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux NFS List <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] direct-IO API change
Date: Fri, 04 Oct 2002 15:37:59 -0700 [thread overview]
Message-ID: <3D9E1847.F6DDA3AE@digeo.com> (raw)
In-Reply-To: Pine.LNX.4.31.0210041525010.59482-100000@torvalds-p95.transmeta.com
Linus Torvalds wrote:
>
> On Fri, 4 Oct 2002, Chuck Lever wrote:
> >
> > this patch adds a "struct file *" argument to direct I/O. this is needed
> > by NFS direct I/O to make the file's credentials available to direct I/O
> > subroutines. we can't remove "struct inode *" yet because the raw driver
> > still needs it.
>
> Why isn't the raw driver changed to just use file->f_dentry->d_inode
> instead?
>
Because the file handle which we have is for /dev/raw/raw0,
not for /dev/hda1.
The raw driver binds to major/minor, not a file*. I considered
changing that (change userspace to pass the open fd). But didn't.
An alternative would be to rewrite i_mapping for /dev/raw/raw0
to be bdev->bd_inode->i_mapping. I guess we should look at doing
that.
next prev parent reply other threads:[~2002-10-04 22:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-04 22:10 [PATCH] direct-IO API change Chuck Lever
2002-10-04 22:25 ` Linus Torvalds
2002-10-04 22:37 ` Andrew Morton [this message]
2002-10-04 23:23 ` Linus Torvalds
2002-10-04 23:35 ` Andrew Morton
2002-10-04 23:44 ` Linus Torvalds
2002-10-04 23:56 ` Badari Pulavarty
2002-10-05 0:11 ` Linus Torvalds
2002-10-08 13:33 ` Terje Eggestad
[not found] ` <Pine.LNX.4.44.0210041621170.2526-100000@home.transmeta.com >
2002-10-05 9:49 ` Lincoln Dale
2002-10-05 19:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D9E1847.F6DDA3AE@digeo.com \
--to=akpm@digeo.com \
--cc=cel@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).