From: Luben Tuikov <luben@splentec.com>
To: Adam Radford <aradford@3WARE.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 3w-xxxx: additional ata->sense codes, avoid driver lockup
Date: Wed, 13 Nov 2002 17:24:16 -0500 [thread overview]
Message-ID: <3DD2D110.C122D161@splentec.com> (raw)
In-Reply-To: A1964EDB64C8094DA12D2271C04B812672C867@tabby
Adam Radford wrote:
>
> Luben,
>
> Thanks for submitting the patch, however, it appears part of it is wrong:
>
> - if ((command->status == 0xc7) || (command->status == 0xcb))
> {
> + if (command->status & 0xC1) {
>
> What makes you think you should not check for c7 or cb, and only check c1?
Hi Adam,
I don't really ``only'' check for 0xc1, it just shows which bits I'm
interested in (0xc1 is a mask anded with the status).
In fact, I'm only interested in the error bit (ERR), but saw what you did
and decided to stay as close to 0xc7 and 0xcb, both of whom are in the
subset of status & 0xC1, (0xC1 == BSY|DRDY|ERR). So in effect 0xC7 and 0xCB
still match.
Anyway, if you are throwing away
if (command->status & 0xC1)
then you might as well throw away flags 0x11 from tw_sense_table[]
and then we're back at ``square 1'' -- this is exactly when the
driver gets into an inf. loop and eventually locks up the machine
and the serial console prints ...
3w-xxxx: scsiX: Command failed: status = 0xc1, flags = 0x11, unit #Y.
... ad infinitum.
I was just trying to avoid this deadlock.
--
Luben
next prev parent reply other threads:[~2002-11-13 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-13 21:57 [PATCH] 3w-xxxx: additional ata->sense codes, avoid driver lo ckup Adam Radford
2002-11-13 22:24 ` Luben Tuikov [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-11-13 22:32 Adam Radford
2002-11-13 23:53 ` [PATCH] 3w-xxxx: additional ata->sense codes, avoid driver lockup Luben Tuikov
2002-11-13 21:00 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD2D110.C122D161@splentec.com \
--to=luben@splentec.com \
--cc=aradford@3WARE.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).