From: hpa@zytor.com
To: Thomas Gleixner <tglx@linutronix.de>, John Hubbard <jhubbard@nvidia.com>
Cc: john.hubbard@gmail.com, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] x86/boot: clear some fields explicitly
Date: Thu, 25 Jul 2019 14:57:10 -0700 [thread overview]
Message-ID: <3DFA2707-89A6-4DD2-8DFB-0C2D1ABA1B3C@zytor.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1907252343180.1791@nanos.tec.linutronix.de>
On July 25, 2019 2:48:30 PM PDT, Thomas Gleixner <tglx@linutronix.de> wrote:
>On Thu, 25 Jul 2019, John Hubbard wrote:
>> On 7/25/19 12:22 AM, Thomas Gleixner wrote:
>> > It removes the clearing of the range between kbd_status and hdr
>without any
>> > replacement. It neither clears edid_info.
>>
>>
>> Yes. Somehow I left that chunk out. Not my finest hour.
>
>S*** happens
>
>> > + char *p = (char *) boot_params;
>> > + int i;
>> > +
>> > + for (i = 0; i < ARRAY_SIZE(toclear); i++)
>> > + memset(p + toclear[i].start, 0, toclear[i].len);
>> > }
>> > }
>>
>> Looks nice.
>
>I have no idea whether it works and I have no cycles either, so I would
>appreciate it if you could polish it up so we can handle that new
>fangled
>GCC "feature" nicely.
>
>Alternatively file a bug report to the GCC folks :)
>
>But seriously I think it's not completely insane what they are doing
>and
>the table based approach is definitely more readable and maintainable
>than
>the existing stuff.
>
>Thanks,
>
> tglx
Doing this table based does seem like a good idea.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2019-07-25 21:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 23:15 [PATCH 0/1] x86/boot: clear some fields explicitly john.hubbard
2019-07-24 23:15 ` [PATCH 1/1] " john.hubbard
2019-07-25 2:12 ` hpa
2019-07-25 6:49 ` John Hubbard
2019-07-25 7:22 ` Thomas Gleixner
2019-07-25 20:33 ` John Hubbard
2019-07-25 21:48 ` Thomas Gleixner
2019-07-25 21:57 ` hpa [this message]
2019-07-25 22:03 ` Thomas Gleixner
2019-07-25 22:28 ` H. Peter Anvin
2019-07-25 22:37 ` Thomas Gleixner
2019-07-26 0:36 ` John Hubbard
2019-07-25 22:42 ` John Hubbard
2019-07-26 7:43 ` Thomas Gleixner
2019-07-25 20:38 ` H. Peter Anvin
2019-07-25 20:44 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DFA2707-89A6-4DD2-8DFB-0C2D1ABA1B3C@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).