From: Corey Minyard <minyard@acm.org>
To: Mauricio Martinez <mauricio@coe.neu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.20 drivers/cdrom/cdu31a.c
Date: Tue, 11 Feb 2003 12:52:49 -0600 [thread overview]
Message-ID: <3E494681.6090200@acm.org> (raw)
In-Reply-To: <Pine.GSO.4.33.0302111235510.29078-100000@Amps.coe.neu.edu>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Mauricio Martinez wrote:
|Thanks for your reply. I guess there are still some drives like this
|floating around. I can live without it, but it is good to use it in an old
|486 as a jukebox and print server :)
|
|Your patch makes much more sense that mine (I have no experience in Linux
|driver development), and it makes the drive work *very well* (excellent
|transfer rate and no system overload), but only if I remove the last hunk.
|
|This last hunk tries to read again the data with 4 sectors less each time
|(i.e. 16,14,12,...,4) which *i think* overloads the buffer leading to an
|oops (and even a system reboot without warning!).
|
|Hope this information helps.
That's really wierd. Can you make the code in question be:
~ } else if (nblock > 0) {
~ printk("Number of blocks left: %d\n", nblock);
~ end_request(1);
~ } else {
and then send the results when it happens?
It turns out my machine does not have an ISA bus slot, so I can't plug
my drive in anywhere.
Thanks,
- -Corey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQE+SUaAIXnXXONXERcRAurxAKCgATRBLbNDprxCKcKdsmrPuVkQggCdEwFX
ZVMPef8C10TZzcjEbIgz09U=
=RF+b
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2003-02-11 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 13:43 [PATCH] 2.4.20 drivers/cdrom/cdu31a.c Mauricio Martinez
2003-02-07 15:48 ` Corey Minyard
2003-02-11 18:10 ` Mauricio Martinez
2003-02-11 18:52 ` Corey Minyard [this message]
2003-02-14 13:53 ` Mauricio Martinez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E494681.6090200@acm.org \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mauricio@coe.neu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).