From: "Karicheri, Muralidharan" <m-karicheri2@ti.com>
To: "Karicheri, Muralidharan" <m-karicheri2@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mturquette@linaro.org" <mturquette@linaro.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"wim@iguana.be" <wim@iguana.be>
Subject: RE: [PATCH] wdt:clk: preparation for switch to common clock framework
Date: Fri, 7 Sep 2012 18:36:44 +0000 [thread overview]
Message-ID: <3E54258959B69E4282D79E01AB1F32B7041B6EB8@DFLE12.ent.ti.com> (raw)
In-Reply-To: <1346351350-28807-1-git-send-email-m-karicheri2@ti.com>
>> -----Original Message-----
>> From: Karicheri, Muralidharan
>> Sent: Thursday, August 30, 2012 2:29 PM
>> To: linux-kernel@vger.kernel.org; mturquette@linaro.org; linux-
>> watchdog@vger.kernel.org; wim@iguana.be
>> Cc: Karicheri, Muralidharan
>> Subject: [PATCH] wdt:clk: preparation for switch to common clock framework
>>
>> As a first step towards migrating davinci platforms to use common clock
>> framework, replace all instances of clk_enable() with clk_prepare_enable()
>> and clk_disable() with clk_disable_unprepare(). Until the platform is
>> switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
>> adds a might_sleep() call and would work without any issues.
>>
>> This will make it easy later to switch to common clk based implementation
>> of clk driver from DaVinci specific driver.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>> drivers/watchdog/davinci_wdt.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
>> index c8c5c80..eb44b03 100644
>> --- a/drivers/watchdog/davinci_wdt.c
>> +++ b/drivers/watchdog/davinci_wdt.c
>> @@ -208,7 +208,7 @@ static int __devinit davinci_wdt_probe(struct platform_device
>> *pdev)
>> if (WARN_ON(IS_ERR(wdt_clk)))
>> return PTR_ERR(wdt_clk);
>>
>> - clk_enable(wdt_clk);
>> + clk_prepare_enable(wdt_clk);
>>
>> if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT)
>> heartbeat = DEFAULT_HEARTBEAT;
>> @@ -256,7 +256,7 @@ static int __devexit davinci_wdt_remove(struct platform_device
>> *pdev)
>> wdt_mem = NULL;
>> }
>>
>> - clk_disable(wdt_clk);
>> + clk_disable_unprepare(wdt_clk);
>> clk_put(wdt_clk);
>>
>> return 0;
>> --
>> 1.7.9.5
subsystem owner,
Could you please review and apply this patch as needed? We need to get this upstream before submitting the patch for Common clock framework support for mach-davinci. If I need to follow a specific procedure to get this merged, please direct me to a process page.
Thanks.
Murali Karicheri
Software Design Engineer
next parent reply other threads:[~2012-09-07 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1346351350-28807-1-git-send-email-m-karicheri2@ti.com>
2012-09-07 18:36 ` Karicheri, Muralidharan [this message]
2012-09-11 21:09 ` [PATCH] wdt:clk: preparation for switch to common clock framework Wim Van Sebroeck
2012-09-07 21:27 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E54258959B69E4282D79E01AB1F32B7041B6EB8@DFLE12.ent.ti.com \
--to=m-karicheri2@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).