From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752920AbbDUMyK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Apr 2015 08:54:10 -0400
Received: from mga02.intel.com ([134.134.136.20]:44197 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751575AbbDUMyG convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Apr 2015 08:54:06 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,616,1422950400"; 
   d="scan'208";a="712883064"
From: "Yu, Fenghua" <fenghua.yu@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: "H. Peter Anvin" <hpa@linux.intel.com>, Ingo Molnar <mingo@kernel.org>,
        "Mallick, Asit K" <asit.k.mallick@intel.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "Williamson, Glenn P" <glenn.p.williamson@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: RE: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes
 enumeration
Thread-Topic: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes
 enumeration
Thread-Index: AQHQehRkpV2whqCkf0Sgpv83fx3dz51XqQAA//+8q+A=
Date: Tue, 21 Apr 2015 12:54:04 +0000
Message-ID: <3E5A0FA7E9CA944F9D5414FEC6C712205C8C5C7F@ORSMSX106.amr.corp.intel.com>
References: <1429387928-28179-1-git-send-email-fenghua.yu@intel.com>
 <alpine.DEB.2.11.1504211101200.13914@nanos>
In-Reply-To: <alpine.DEB.2.11.1504211101200.13914@nanos>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.22.254.138]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Thomas Gleixner [mailto:tglx@linutronix.de]
> Sent: Tuesday, April 21, 2015 2:17 AM
> On Sat, 18 Apr 2015, Fenghua Yu wrote:
> 
> > From: Fenghua Yu <fenghua.yu@intel.com>
> >
> > When enumerating xstate offsets and sizes from cpuid (eax=0x0d,
> > ecx>=2), it's possible that state m is not implemented while state n
> > (n>m) is implemented. So enumeration shouldn't stop at state m.
> >
> > There is no platform configured like above yet. But this could be a
> > problem in the future.
> 
> So this is for future hardware. Why are you claiming this is a BUGFIX?

I think the current code does not follow xstate offsets and sizes
definition based on SDM. So it is buggy. When platforms have more
xsates, it's becoming more possible to hit the issue because platforms
have more chances to disable some xstates and leave holes in xsave
area. And I do see an internal platform may hit the issue. That's why I
claim this is a BUGFIX.

> 
> This is a regular hardware enablement or are you saying that this is backport
> material?

I would like the patch to be backported to distros or stable kernel because
we may really see the issue in near future if it's not backported.

> 
> Confused.

Thanks.

-Fenghua