From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751292AbcGMVSc (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jul 2016 17:18:32 -0400
Received: from mga04.intel.com ([192.55.52.120]:25209 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751053AbcGMVSW convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jul 2016 17:18:22 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,359,1464678000"; 
   d="scan'208";a="138704253"
From: "Yu, Fenghua" <fenghua.yu@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@elte.hu>, "Anvin, H Peter" <h.peter.anvin@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>, Tejun Heo <tj@kernel.org>,
        "Borislav Petkov" <bp@suse.de>, Stephane Eranian <eranian@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        "David Carrillo-Cisneros" <davidcc@google.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        Vikas Shivappa <vikas.shivappa@linux.intel.com>,
        "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: RE: [PATCH 08/32] Define CONFIG_INTEL_RDT
Thread-Topic: [PATCH 08/32] Define CONFIG_INTEL_RDT
Thread-Index: AQHR3IkKtnF0IsW28UqzbHe3S6UBtaAWnhOAgAAHXDCAAKyJgP//jDtA
Date: Wed, 13 Jul 2016 21:18:20 +0000
Message-ID: <3E5A0FA7E9CA944F9D5414FEC6C712205DFD4BAF@ORSMSX106.amr.corp.intel.com>
References: <1468371785-53231-1-git-send-email-fenghua.yu@intel.com>
 <1468371785-53231-9-git-send-email-fenghua.yu@intel.com>
 <alpine.DEB.2.11.1607131223020.4083@nanos>
 <3E5A0FA7E9CA944F9D5414FEC6C712205DFD4AB3@ORSMSX106.amr.corp.intel.com>
 <alpine.DEB.2.11.1607132303580.4083@nanos>
In-Reply-To: <alpine.DEB.2.11.1607132303580.4083@nanos>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.22.254.140]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Thomas Gleixner [mailto:tglx@linutronix.de]
> Sent: Wednesday, July 13, 2016 2:10 PM
> On Wed, 13 Jul 2016, Yu, Fenghua wrote:
> > Here is why this patch behaves like this:
> >
> > This patch and actually first 12 patches are directly from last year's
> > cgroup base CAT patch series. The last year's patch series had gone 16
> > versions already. Because the first 12 patches have been reviewed many
> > times, we keep them untouched (except removing cgroup code in patch 8
> > and some unused cdp code in patch 11) and release other patches on top
> > of the first 12 patches.
> 
> Which is not making the review any simpler. In order to understand the
> modifications I have to go back and page in the original stuff from last year
> once again. So I have to read the original patch first to understand the
> modifications and then get the overall picture of the new stuff. Please fold
> stuff back to the proper places so I can start reviewing this thing under the
> new design idea instead of twisting my brain around two designs.

Ok. I will do that.

> 
> > I fully agree this patch should be split if we want to have a good
> > overall patch series.
> 
> Good.
> 
> Thanks,
> 
> 	tglx