From: Dan Kegel <dank@kegel.com>
To: Steven Cole <elenstev@mesatop.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Matthias Schniedermeyer <ms@citd.de>,
Joe Perches <joe@perches.com>,
mike@aiinc.ca,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel source spellchecker
Date: Sun, 02 Mar 2003 21:48:40 -0800 [thread overview]
Message-ID: <3E62ECB8.4010409@kegel.com> (raw)
In-Reply-To: <1046668274.7527.533.camel@spc1.mesatop.com>
Steven Cole wrote:
> BTW, I ran the spell-fix.pl script using only the first 10 entries
> of spell-fix.txt (an arbitrary choice), and got a pretty big diff:
>
> 132 files changed, 199 insertions(+), 199 deletions(-)
>
> My feeling is that patches should be about 1/4 that size.
> Otherwise, Linus may /dev/null them. Second opinion anyone?
I agree with the 1/4th, but in # of lines of spell-fix.txt, not
in output size.
Looking at the changesets he's accepted, it looks like he's
comfortable with changesets of 100 files (see "don't" fixes at
http://www.kernel.org/pub/linux/kernel/v2.5/testing/cset/cset-1.1025.1.38.txt )
It probably helps that this was a single kind of change.
My guess is these things need enough manual reviewing
that keeping it down to just a related group of fixes per patch
is a good idea (e.g.
Acknowledge=Acknowlege
acknowledged=acknoledged
together are a Good Idea, more is probably bad).
BTW Linus has been accepting so many spell fixes it's probably important
to work with very fresh sources...
- Dan
--
Dan Kegel
http://www.kegel.com
http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
next prev parent reply other threads:[~2003-03-03 5:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-27 6:59 [PATCH] kernel source spellchecker Dan Kegel
[not found] ` <1046330232.15763.97.camel@localhost.localdomain>
2003-03-01 5:38 ` Dan Kegel
2003-03-01 14:11 ` Matthias Schniedermeyer
2003-03-01 17:13 ` Matthias Schniedermeyer
2003-03-01 18:54 ` Dan Kegel
2003-03-01 19:18 ` Steven Cole
2003-03-01 21:20 ` Dan Kegel
2003-03-02 3:45 ` jw schultz
2003-03-02 2:08 ` Dan Kegel
2003-03-02 3:02 ` Dan Kegel
2003-03-02 3:54 ` Steven Cole
2003-03-02 8:04 ` Dan Kegel
2003-03-02 4:16 ` Steven Cole
2003-03-02 8:21 ` Dan Kegel
2003-03-02 8:40 ` jw schultz
2003-03-02 11:21 ` David Woodhouse
2003-03-02 13:49 ` Steven Cole
2003-03-02 14:55 ` David Woodhouse
2003-03-02 22:44 ` Alan Cox
2003-03-02 22:59 ` John Bradford
2003-03-03 2:29 ` Dan Kegel
[not found] ` <3E62C0FF.1090700@kegel.com>
[not found] ` <1046661777.7527.518.camel@spc1.mesatop.com>
2003-03-03 5:36 ` Dan Kegel
[not found] ` <3E62E4C0.9070103@kegel.com>
[not found] ` <1046668274.7527.533.camel@spc1.mesatop.com>
2003-03-03 5:48 ` Dan Kegel [this message]
2003-03-02 15:35 ` Dan Kegel
2003-03-02 8:09 ` Matthias Schniedermeyer
2003-03-02 8:13 ` Matthias Schniedermeyer
2003-03-02 3:29 ` Steven Cole
2003-03-01 19:30 ` Matthias Schniedermeyer
2003-03-01 20:33 ` Matthias Schniedermeyer
2003-03-01 21:25 ` Dan Kegel
2003-03-01 21:25 ` Matthias Schniedermeyer
2003-03-02 9:15 ` John Bradford
2003-03-02 9:31 ` Matthias Schniedermeyer
2003-03-02 3:16 ` Horst von Brand
2003-03-01 15:57 shaheed
2003-03-01 16:35 ` Jörn Engel
2003-03-01 18:01 ` shaheed
2003-03-01 18:31 ` Jörn Engel
2003-03-05 18:10 ` Pavel Machek
[not found] <20030301160017$56fc@gated-at.bofh.it>
2003-03-01 18:39 ` Pascal Schmidt
2003-03-02 18:56 Jared Daniel J. Smith
2003-03-02 17:22 ` Bernd Petrovitsch
2003-03-02 17:47 ` Werner Almesberger
2003-03-02 18:28 ` Bernd Petrovitsch
2003-03-02 18:46 ` Steven Cole
2003-03-02 22:32 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E62ECB8.4010409@kegel.com \
--to=dank@kegel.com \
--cc=dwmw2@infradead.org \
--cc=elenstev@mesatop.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@aiinc.ca \
--cc=ms@citd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).