From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932653AbcCCP2o (ORCPT ); Thu, 3 Mar 2016 10:28:44 -0500 Received: from torg.zytor.com ([198.137.202.12]:46780 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757064AbcCCP2m (ORCPT ); Thu, 3 Mar 2016 10:28:42 -0500 User-Agent: K-9 Mail for Android In-Reply-To: <20160303134314.7098f033@canb.auug.org.au> References: <20160303092134.7c750589@canb.auug.org.au> <55b63eefc347f1bb28573f972d8d1adbf1f1c31d.1456962210.git.jpoimboe@redhat.com> <20160303134314.7098f033@canb.auug.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 2/2] objtool: Support CROSS_COMPILE From: "H. Peter Anvin" Date: Thu, 03 Mar 2016 07:23:30 -0800 To: Stephen Rothwell , Josh Poimboeuf CC: Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Adrian Hunter , Michael Ellerman , Peter Zijlstra , Thomas Gleixner Message-ID: <3E86758B-9678-4CCF-8A16-C4DDAE05A19C@zytor.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On March 2, 2016 6:43:14 PM PST, Stephen Rothwell wrote: >Hi Josh, > >Just a couple of quick comments ... > >On Wed, 2 Mar 2016 18:39:37 -0600 Josh Poimboeuf >wrote: >> >> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile >> index c4f0713..e4a6bd5 100644 >> --- a/tools/objtool/Makefile >> +++ b/tools/objtool/Makefile > >I was wondering if this would be more appropriate in scripts/objtool >since it is used during the building of the kernel. Or does it have a >wider use? > >> @@ -7,13 +7,19 @@ ARCH := x86 >> endif >> endif >> >> +# always use the host compiler >> +CC = gcc > >We have HOSTCC with its associated HOSTCFLAGS etc ... I am not sure if >that is more appropriate (but it does take care of people using clang). This is what HOSTCC is for. And yes, this belongs in scripts. -- Sent from my Android device with K-9 Mail. Please excuse brevity and formatting.