From: Jeff Garzik <jgarzik@pobox.com>
To: Rusty Trivial Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL] kstrdup
Date: Fri, 18 Apr 2003 04:10:17 -0400 [thread overview]
Message-ID: <3E9FB2E9.9040308@pobox.com> (raw)
In-Reply-To: <20030418080205.A21702C2E1@lists.samba.org>
Rusty Trivial Russell wrote:
> +char *kstrdup(const char *s, int gfp)
> +{
> + char *buf = kmalloc(strlen(s)+1, gfp);
> + if (buf)
> + strcpy(buf, s);
> + return buf;
> +}
You should save the strlen result to a temp var, and then s/strcpy/memcpy/
Jeff
next prev parent reply other threads:[~2003-04-18 7:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-18 7:58 [TRIVIAL] kstrdup Rusty Trivial Russell
2003-04-18 8:10 ` Jeff Garzik [this message]
2003-04-18 16:20 ` Linus Torvalds
2003-04-18 16:56 ` Jeff Garzik
2003-04-18 18:00 ` Linus Torvalds
2003-04-18 18:44 ` Jeff Garzik
2003-04-19 4:52 ` Rusty Russell
2003-04-18 18:00 ` Richard B. Johnson
2003-04-18 18:40 ` Jeff Garzik
2003-04-18 19:24 ` H. Peter Anvin
2003-04-18 23:37 ` Alan Cox
2003-04-18 19:29 ` Richard B. Johnson
2003-04-19 11:45 ` Kai Henningsen
2003-04-19 20:16 ` Ruth Ivimey-Cook
2003-04-19 4:14 ` Rusty Russell
2003-04-19 4:48 ` Jeff Garzik
2003-04-19 8:28 ` Rusty Russell
2003-04-19 12:27 ` Alan Cox
2003-04-19 14:44 ` Bernd Eckenfels
2003-04-20 8:05 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E9FB2E9.9040308@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).