From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263461AbTDXQ52 (ORCPT ); Thu, 24 Apr 2003 12:57:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263769AbTDXQ52 (ORCPT ); Thu, 24 Apr 2003 12:57:28 -0400 Received: from dyn-ctb-210-9-246-63.webone.com.au ([210.9.246.63]:58884 "EHLO chimp.local.net") by vger.kernel.org with ESMTP id S263461AbTDXQ50 (ORCPT ); Thu, 24 Apr 2003 12:57:26 -0400 Message-ID: <3EA81A3B.80800@cyberone.com.au> Date: Fri, 25 Apr 2003 03:09:15 +1000 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030327 Debian/1.3-4 X-Accept-Language: en MIME-Version: 1.0 To: Jens Axboe CC: Zwane Mwaikambo , Linux Kernel Subject: Re: Badness in as-iosched:1210 References: <3EA7A0CC.50005@cyberone.com.au> <20030424084717.GF8775@suse.de> In-Reply-To: <20030424084717.GF8775@suse.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jens Axboe wrote: >On Thu, Apr 24 2003, Nick Piggin wrote: > >>Zwane Mwaikambo wrote: >> >> >>>I'm not sure wether you want this, it was during error handling from the >>>HBA driver (source was disk error). >>> >>>scsi1: ERROR on channel 0, id 3, lun 0, CDB: Read (10) 00 00 7f de 60 00 >>>00 80 00 Info fld=0x7fdeb2, Current sdd: sense key Medium Error >>>Additional sense: Unrecovered read error >>>end_request: I/O error, dev sdd, sector 8380032 >>>Badness in as_add_request at drivers/block/as-iosched.c:1210 >>> >>> >>Thanks I'll have a look. >> > >The debug check looks broken, request could have come from somewhere >else than the block pool. > Thats right. I thought these requests would all be !blk_fs_request()s though. It should be only the debug checks which are wrong.