From: Jeff Garzik <jgarzik@pobox.com>
To: Jim Keniston <jkenisto@us.ibm.com>
Cc: Joe Perches <joe@perches.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Feldman, Scott" <scott.feldman@intel.com>,
Greg KH <greg@kroah.com>, Janice Girard <girouard@us.ibm.com>,
LOS team <losteam@intel.com>, Phil Cayton <phil.cayton@intel.com>,
Randy Dunlap <rddunlap@osdl.org>,
Larry Kessler <kessler@us.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH] Net device error logging
Date: Mon, 05 May 2003 14:10:17 -0400 [thread overview]
Message-ID: <3EB6A909.9090901@pobox.com> (raw)
In-Reply-To: <3EB3026C.604D6F4C@us.ibm.com>
Jim Keniston wrote:
> I'm happy to discuss this. As I see it, there are at least 4
> possibilities:
> 1. Standardize on the netif_msg_xxx (bit map) approach.
> 2. Standardize on simple reporting levels (if (debug >= 2)...).
> 3. Make the driver provide a filtering function, which can do #1, #2 or
> some
> other driver-specific test.
> 4. Status quo: make the message-level test before calling netdev_xxx.
Number one is the desired direction for net drivers.
> I think message filtering is a good idea. I also think the following
> features
> would be useful:
> a. Identify which device and driver the message refers to.
this is already done in net drivers
> b. Call net_ratelimit() in appropriate contexts.
this is questionable. The netif_xxx messages are _already_ designed to
be used in order of increasing verbosity. If the user selects the more
verbose class of messages, then rate-limiting may not be appropriate.
> c. Capture caller info (__FILE__ and/or __FUNCTION__).
No need, in net drivers. All of them already print out network
interface, which is all you need to know.
> e. Standardize certain messages so that all drivers log predictable,
> standard
> messages (perhaps along with driver-specific info) under certain
> circumstances.
Yes, standardization of net driver messages is desired.
Jeff
next prev parent reply other threads:[~2003-05-05 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-01 17:24 [RFC] [PATCH] Net device error logging Jim Keniston[UNIX]
[not found] ` <1051816594.29929.32.camel@localhost.localdomain>
[not found] ` <3EB1A718.1084972F@us.ibm.com>
[not found] ` <1051894225.2664.62.camel@localhost.localdomain>
2003-05-02 23:42 ` Jim Keniston
2003-05-05 18:10 ` Jeff Garzik [this message]
2003-05-07 0:47 ` Jim Keniston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB6A909.9090901@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=girouard@us.ibm.com \
--cc=greg@kroah.com \
--cc=jkenisto@us.ibm.com \
--cc=joe@perches.com \
--cc=kessler@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=losteam@intel.com \
--cc=phil.cayton@intel.com \
--cc=rddunlap@osdl.org \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).