From: Michael Hunold <hunold@convergence.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH[[2.5][3-11] update dvb subsystem core
Date: Wed, 07 May 2003 11:19:30 +0200 [thread overview]
Message-ID: <3EB8CFA2.5090405@convergence.de> (raw)
In-Reply-To: <20030506214918.A18262@infradead.org>
Hello Christoph,
>>- partly reintroduced the DVB_DEVFS_ONLY switch, which was previously
>>wiped out by Alan Cox: if enabled, some really obscure code is not
>>compiled into the kernel that is necessary to xxx
>
>
> No, this is wrong. I did remove it not Alan Cox and I removed it because
> kernel 2.5/2.6 should not behave differently whether devfs is used or
> not except nodes showing up in devfs.
The code does not behave differently. If DVB_DEVFS_ONLY is set, then the
old chardev register interface is omitted.
We use the dvb subsystem on set-top-boxes where devfs is present only.
The DVB_DEVFS_ONLY switch then lets us save some bytes and skips the
"map-minor-to-actual-device" function stuff.
>>- /* fixme: is this correct? */
>>- try_module_get(THIS_MODULE);
>>+
>
>
> Just removing this makes the code even more incorrect. You need to
> add a ->owner member and call try_module_get on it before calling into
> the module (and handle the return value..)
There is a functional dependency between the dvb-core and the actual dvb
driver. So there is no need to increase the module count of the dvb-core
if a new adapter is registered IMHO, because you cannot unload the
dvb-core before the driver anyway.
>>-typedef struct dmxdev_dvr_s {
>>+typedef struct dmxdev_dvr {
>> int state;
>>- struct dmxdev_s *dev;
>>+ struct dmxdev *dev;
>> dmxdev_buffer_t buffer;
>> } dmxdev_dvr_t;
>
>
> Once you rename everything you can nuke the typedef crap aswel..
Thanks, added to the TODO list.
CU
Michael.
next prev parent reply other threads:[~2003-05-07 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 16:04 [PATCH[[2.5][3-11] update dvb subsystem core Michael Hunold
2003-05-06 20:49 ` Christoph Hellwig
2003-05-07 9:19 ` Michael Hunold [this message]
2003-05-07 9:28 ` Christoph Hellwig
2003-05-07 15:56 ` Michael Hunold
2003-05-07 16:04 ` Christoph Hellwig
2003-05-06 21:08 ` Christoph Hellwig
2003-05-07 8:40 ` Michael Hunold
2003-05-07 9:22 ` Christoph Hellwig
2003-05-07 15:56 ` Michael Hunold
2003-05-07 15:59 ` Christoph Hellwig
2003-05-07 16:14 ` Michael Hunold
2003-05-07 16:15 ` Christoph Hellwig
2003-05-07 18:30 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB8CFA2.5090405@convergence.de \
--to=hunold@convergence.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).