xfs don't compil in linux-2.5 BK

xfs don't compil in linux-2.5 BK

[Gregoire Favre]

Hello,

I don't know if I have fetched the source with BK the right way...
Anyway the compil ends that way:

  CC      fs/xfs/xfs_rw.o
  CC      fs/xfs/pagebuf/page_buf.o
In file included from fs/xfs/pagebuf/page_buf.c:65:
fs/xfs/pagebuf/page_buf_internal.h:46:24: operator '<' has no left
operand
make[2]: *** [fs/xfs/pagebuf/page_buf.o] Error 1
make[1]: *** [fs/xfs] Error 2
make: *** [fs] Error 2
141.112u 14.914s 3:19.78 78.0%  0+0k 0+0io 492771pf+0w
Exit 2


	Grégoire
__________________________________________________________________
http://www-ima.unil.ch/greg ICQ:16624071 mailto:greg@magma.unil.ch

Re: xfs don't compil in linux-2.5 BK

[Grzegorz Jaskiewicz]

On Mon, 2003-05-26 at 20:31, Gregoire Favre wrote:
> Hello,
> 
> I don't know if I have fetched the source with BK the right way...
> Anyway the compil ends that way:
> 
>   CC      fs/xfs/xfs_rw.o
>   CC      fs/xfs/pagebuf/page_buf.o
> In file included from fs/xfs/pagebuf/page_buf.c:65:
> fs/xfs/pagebuf/page_buf_internal.h:46:24: operator '<' has no left
> operand
> make[2]: *** [fs/xfs/pagebuf/page_buf.o] Error 1
> make[1]: *** [fs/xfs] Error 2
> make: *** [fs] Error 2
> 141.112u 14.914s 3:19.78 78.0%  0+0k 0+0io 492771pf+0w
> Exit 2

looks like LINUX_VERSION_CODE is not defined
try this (as 2.5.69 > than 2.5.9)

diff -ur 2/fs/xfs/pagebuf/page_buf_internal.h
1/fs/xfs/pagebuf/page_buf_internal.h
--- 2/fs/xfs/pagebuf/page_buf_internal.h        2003-05-05
00:53:14.000000000 +0100
+++ 1/fs/xfs/pagebuf/page_buf_internal.h        2003-05-26
22:59:27.000000000 +0100
@@ -43,11 +43,6 @@
 #define PB_DEFINE_TRACES
 #include "page_buf_trace.h"

-#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,9)
-#define page_buffers(page)     ((page)->buffers)
-#define page_has_buffers(page) ((page)->buffers)
-#endif
-
 #ifdef PAGEBUF_LOCK_TRACKING
 #define PB_SET_OWNER(pb)       (pb->pb_last_holder = current->pid)
 #define PB_CLEAR_OWNER(pb)     (pb->pb_last_holder = -1)




-- 
Grzegorz Jaskiewicz <gj@pointblue.com.pl>
K4 labs

Re: xfs don't compil in linux-2.5 BK

[Gregoire Favre]

On Mon, May 26, 2003 at 11:01:12PM +0100, Grzegorz Jaskiewicz wrote:

> looks like LINUX_VERSION_CODE is not defined
> try this (as 2.5.69 > than 2.5.9)

Well, maybe BK is not for me:

greg@greg:linux >make dep && make bzImage && make modules && sudo make modules_install
*** Warning: make dep is unnecessary now.
make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
  Starting the build. KBUILD_BUILTIN=1 KBUILD_MODULES=
  CHK     include/linux/compile.h
dnsdomainname: Unknown host
  CC      fs/xfs/pagebuf/page_buf.o
In file included from fs/xfs/pagebuf/page_buf.c:65:
fs/xfs/pagebuf/page_buf_internal.h:46:24: operator '<' has no left operand
fs/xfs/pagebuf/page_buf_internal.h:51:24: operator '<' has no left operand
make[2]: *** [fs/xfs/pagebuf/page_buf.o] Error 1
make[1]: *** [fs/xfs] Error 2
make: *** [fs] Error 2
Exit 2

Thank you very much,

	Grégoire
__________________________________________________________________
http://www-ima.unil.ch/greg ICQ:16624071 mailto:greg@magma.unil.ch

Re: xfs don't compil in linux-2.5 BK

[Nathan Scott]

On Tue, May 27, 2003 at 12:38:03AM +0200, Gregoire Favre wrote:
> On Mon, May 26, 2003 at 11:01:12PM +0100, Grzegorz Jaskiewicz wrote:
> 
> > looks like LINUX_VERSION_CODE is not defined
> > try this (as 2.5.69 > than 2.5.9)
> 
> Well, maybe BK is not for me:
> 
> greg@greg:linux >make dep && make bzImage && make modules && sudo make modules_install
> *** Warning: make dep is unnecessary now.

Are you missing "make oldconfig" or one of the other *config targets,
perhaps?  Looks like some parts of your build haven't been done before
you descend into fs/xfs - in particular, your <linux/version.h> header
doesn't seem to have good stuff in it.

cheers.

> make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
>   Starting the build. KBUILD_BUILTIN=1 KBUILD_MODULES=
>   CHK     include/linux/compile.h
> dnsdomainname: Unknown host
>   CC      fs/xfs/pagebuf/page_buf.o
> In file included from fs/xfs/pagebuf/page_buf.c:65:
> fs/xfs/pagebuf/page_buf_internal.h:46:24: operator '<' has no left operand
> fs/xfs/pagebuf/page_buf_internal.h:51:24: operator '<' has no left operand
> make[2]: *** [fs/xfs/pagebuf/page_buf.o] Error 1
> make[1]: *** [fs/xfs] Error 2
> make: *** [fs] Error 2
> Exit 2
> 
> Thank you very much,
> 
> 	Grégoire
> __________________________________________________________________
> http://www-ima.unil.ch/greg ICQ:16624071 mailto:greg@magma.unil.ch
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Nathan

Re: xfs don't compil in linux-2.5 BK

[Carl-Daniel Hailfinger]

Gregoire Favre wrote:
> On Mon, May 26, 2003 at 11:01:12PM +0100, Grzegorz Jaskiewicz wrote:
> 
> 
>>looks like LINUX_VERSION_CODE is not defined
>>try this (as 2.5.69 > than 2.5.9)
> 
> 
> Well, maybe BK is not for me:
> 
> greg@greg:linux >make dep && make bzImage && make modules && sudo make modules_install
> *** Warning: make dep is unnecessary now.
> make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
>   Starting the build. KBUILD_BUILTIN=1 KBUILD_MODULES=
>   CHK     include/linux/compile.h
> dnsdomainname: Unknown host
>   CC      fs/xfs/pagebuf/page_buf.o
> In file included from fs/xfs/pagebuf/page_buf.c:65:
> fs/xfs/pagebuf/page_buf_internal.h:46:24: operator '<' has no left operand
> fs/xfs/pagebuf/page_buf_internal.h:51:24: operator '<' has no left operand
> make[2]: *** [fs/xfs/pagebuf/page_buf.o] Error 1
> make[1]: *** [fs/xfs] Error 2
> make: *** [fs] Error 2
> Exit 2

if you are using bk, maybe not all files were checked out? Try

bk -r get

and if the error still does not go away,

make mrproper

and then

make {,x,menu}config

make dep does nothing in 2.5 and make bzImage is standard target, so you
can abbreviate you command line to

make && make modules && sudo make modules_install


HTH,
Carl-Daniel
-- 
http://www.hailfinger.org/

Re: xfs don't compil in linux-2.5 BK

[Gregoire Favre]

On Tue, May 27, 2003 at 01:52:18AM +0200, Carl-Daniel Hailfinger wrote:

> if you are using bk, maybe not all files were checked out? Try
> 
> bk -r get
> 
> and if the error still does not go away,
> 
> make mrproper
> 
> and then
> 
> make {,x,menu}config
> 
> make dep does nothing in 2.5 and make bzImage is standard target, so you
> can abbreviate you command line to
> 
> make && make modules && sudo make modules_install

Thank you very much for your answer, I have tried the bk -r get, but I
didn't get the 2.5.70 in the Makefile...
I am a little bit lost with bk. Finally I tried:
bk pull
bk -r co

And then I got the 2.5.70 and it still compiling it ;-)
(the xfs stuff is passed).

Sorry for the complete off-topic: I use DVB, and most of the time, the
one included in the kernel is outdated and I took the one from
cvs -q -z3 -d :pserver:anonymous@linuxtv.org:/cvs/linuxtv co dvb-kernel
and the dvb-kernel/makelinks replace some files from the kernel with
symlinks: could I then use bk to update after?

An hudge thank,

	Grégoire
__________________________________________________________________
http://www-ima.unil.ch/greg ICQ:16624071 mailto:greg@magma.unil.ch

Re: xfs don't compil in linux-2.5 BK

[Gregoire Favre]

On Tue, May 27, 2003 at 09:21:44AM +1000, Nathan Scott wrote:

> Are you missing "make oldconfig" or one of the other *config targets,
> perhaps?  Looks like some parts of your build haven't been done before
> you descend into fs/xfs - in particular, your <linux/version.h> header
> doesn't seem to have good stuff in it.

I have done a fresh bk checkout, and used (which I now know to be
outdated) (after having copied the .config from my 2.5.69).

make oldconfig && make menuconfig && make dep && make bzImage && make modules && sudo make modules_install

Certainly I did something totally wrong with bk :-(

Thank you,

	Grégoire
__________________________________________________________________
http://www-ima.unil.ch/greg ICQ:16624071 mailto:greg@magma.unil.ch