linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Zwane Mwaikambo <zwane@linuxpower.ca>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@digeo.com>
Subject: Re: [PATCH] xirc2ps_cs irq return fix
Date: Mon, 26 May 2003 23:49:18 -0400	[thread overview]
Message-ID: <3ED2E03E.80004@pobox.com> (raw)
In-Reply-To: <1053992128.17129.15.camel@dhcp22.swansea.linux.org.uk>

Alan Cox wrote:
> On Llu, 2003-05-26 at 02:00, Zwane Mwaikambo wrote:
> 
>>My interpretation of it is the PCMCIA controller was triggering interrupts 
>>on exit and the link handler for the card was still installed even after 
>>the netdevice was down.
> 
> 
> This is exactly what will happen all the time on PCMCIA devices. The
> edge triggered interrupt will cause an IRQ to float around every remove
> of the device on most hardware
> 
> The fix is basically correct, although the odd floating IRQ ought to be
> cleaned up by the heuristics being fixed in the core IRQ disaster
> detector


huh?

If the fix is correct, we need to do a bombing run that adds the 
following code to each driver,

	if (!netif_device_present(dev))
		return IRQ_HANDLED;

but of course the irq _wasn't_ handled by the driver.  Silly, isn't it?

I still maintain it needs to be fixed elsewhere.  Touching every driver 
for this is just not scalable, in addition to pointing the finger at the 
pcmcia core instead of individual drivers.

	Jeff



  reply	other threads:[~2003-05-27  3:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200305252318.h4PNIPX4026812@hera.kernel.org>
2003-05-26  0:44 ` [PATCH] xirc2ps_cs irq return fix Jeff Garzik
2003-05-26  1:00   ` Zwane Mwaikambo
2003-05-26 23:35     ` Alan Cox
2003-05-27  3:49       ` Jeff Garzik [this message]
2003-05-27  3:55         ` Andrew Morton
2003-05-27  9:40           ` Alan Cox
2003-05-27 10:45             ` Andrew Morton
2003-05-27 10:40               ` Alan Cox
2003-05-27 19:37                 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ED2E03E.80004@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@digeo.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zwane@linuxpower.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).