linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* 2.5.70-mm5
@ 2003-06-05  9:12 Andrew Morton
  2003-06-05 11:57 ` 2.5.70-mm5 new oops that wasn't in 2.5.70-mm4 Helge Hafting
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Andrew Morton @ 2003-06-05  9:12 UTC (permalink / raw)
  To: linux-kernel, linux-mm


ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.70/2.5.70-mm5/

. Hopefully fixed a JBD race which can cause every-second-day assertion
  failures in journal_dirty_metadata().

. The AIO infrastructure has been extended to cover O_SYNC writes.




Changes since 2.5.70-mm4:


 linus.patch

 Latest -bk

-aio-random-cleanups.patch
-time-interpolator-cleanup.patch
-cadetradio-badcopy.patch
-cmpci-userptr.patch
-zr36120-userptr.patch
-truncate-vs-msync-fix.patch
-pnpbios-oops-leak-fix.patch
-bw-qcam-fix.patch
-devfs_remove-fix.patch
-generic_file_write-fix-2.patch
-reiserfs-parser-fix-remount.patch
-reiserfs-small-blocksize.patch
-raid-fixes.patch
-neilb-raid1-double-free-fix.patch
-hugetlbfs-mount-options.patch
-raid5-use-right-dev-fix.patch
-deadline-hash-removal-fix.patch
-thread-info-in-task_struct.patch
-journal_create-deadlock-fix.patch

 Merged

+mem_driver_cleanup.patch

 drivers/char/mem.c cleanups and fixes

+remove-get_current_user.patch

 get_current_user() has no users.

+de_thread-BUG-fix.patch

 Remove a triggerable BUG

+hweight64-warning-fix.patch

 Fix all those gcc-3.3 warnings.

+as-stupid.patch
+as-no-batch-antic-limit.patch

 Anticipatory scheduler fixes & tweaks.

+dac960-negotiation-fix.patch

 DAC960 fix

-reinstate-task-freeing-hack-for-ia64.patch

 Dropped, unneeded.

-event-log-put_task_struct.patch

 Dropped - it didn't actually print anything when the bug triggered anyway.

-ext3-orlov-approx-counter-fix.patch
-ext3-concurrent-block-allocation-fix-1.patch
-ext3-concurrent-block-inode-allocation-fix.patch
-jbd-300-remove-lock_kernel-journal_c.patch
-jbd-310-remove-lock_kernel-transaction_c.patch
-jbd-400-remove-lock_journal-checkpoint_c.patch
-jbd-410-remove-lock_journal-commit_c.patch
-jbd-420-remove-lock_journal-journal_c.patch
-jbd-430-remove-lock_journal-transaction_c.patch
-jbd-440-remove-lock_journal.patch
+jbd-300-remove-lock_kernel.patch
+jbd-400-remove-lock_journal.patch

 Various things rolled into other things.

+jbd-620-commit-vs-start-race-fix.patch

 Fix race between start_transaction() and kjournald.

+aio-09-o_sync.patch

 AIO treatment for O_SYNC writes.





All 157 patches


linus.patch

kconfig-dont-scrog--my-config.patch

mm.patch
  add -mmN to EXTRAVERSION

kgdb-ga.patch
  kgdb stub for ia32 (George Anzinger's one)

kgdb-use-ggdb.patch

kmalloc_percpu-interface-change.patch
  kmalloc_percpu: interface change.

kmalloc_percpu-interface-change-warning-fix.patch
  nail a warning

DEFINE_PERCPU-in-modules.patch
  per-cpu support inside modules (minimal)

config_spinline.patch
  uninline spinlocks for profiling accuracy.

ppc64-fixup.patch
  ppc64 fixup

ppc64-ioctl-pci-update.patch
  From: Anton Blanchard <anton@samba.org>
  Subject: ppc64 stuff

ppc64-reloc_hide.patch

ppc64-semaphore-reimplementation.patch
  ppc64: use the ia32 semaphore implementation

sym-do-160.patch
  make the SYM driver do 160 MB/sec

irqreturn-snd-via-fix.patch
  via sound irqreturn fix

irq_cpustat-cleanup.patch
  irq_cpustat cleanup

config-PAGE_OFFSET.patch
  Configurable kenrel/user memory split

irq-check-rate-limit.patch
  IRQs: handle bad return values from handlers

irq_desc-others.patch
  Fix up irq_desc initialisation for non-ia32

common-ioctl32.patch
  From: Pavel Machek <pavel@suse.cz>
  Subject: Re: must-fix list, v5

ioctl32-cleanup-sparc64.patch
  ioctl32 cleanup: sparc64

ioctl32-cleanup-x86_64.patch
  ioctl32 cleanup: sparc64

lru_cache_add-check.patch
  lru_cache_add debug check

eat-keys-on-panic.patch
  Eat keys on panic

force_successful_syscall_return.patch
  force_successful_syscall_return

mem_driver_cleanup.patch
  driver/char/mem.c cleanup

proc-stat-btime-fix.patch
  fix wobbly /proc/stat:btime

eventpoll-use-after-free-fix.patch
  eventpoll: fix possible use-after-free

console-blanking-fix.patch
  Console blanking fix

console-privacy.patch
  Console privacy for braille users

fix-tty-driver-mess.patch
  Fix tty devfs mess

misc3.patch
  misc fixes

fb-image-depth-fix.patch
  fbdev image depth fix

buffer-debug.patch
  buffer.c debugging

cs423x-fixes.patch
  cs423x fixes

remove-get_current_user.patch
  remove get_current_user()

de_thread-BUG-fix.patch
  remove triggerable BUG() from de_thread

statfs64.patch
  Add system calls statfs64 and fstatfs64

statfs64-fix.patch

statfs-overflow-fix.patch
  statfs64: handle overflows

statfs64-leftovers.patch
  statfs64: remaining filesystems

sched_best_cpu-fix-01.patch
  Fix Bug 619: Processes Scheduled on CPU-less nodes (1/3)

sched_best_cpu-fix-02.patch
  Processes Scheduled on CPU-less nodes (2/3)

sched_best_cpu-fix-03.patch
  Fix Bug 619: Processes Scheduled on CPU-less nodes (3/3)

hweight64-warning-fix.patch

VM_RESERVED-check.patch
  VM_RESERVED check

rcu-stats.patch
  RCU statistics reporting

ide_setting_sem-fix.patch

reslabify-pgds-and-pmds.patch
  re-slabify i386 pgd's and pmd's

linux-isp.patch

isp-update-1.patch

list_del-debug.patch
  list_del debug check

airo-schedule-fix.patch
  airo.c: don't sleep in atomic regions

synaptics-mouse-support.patch
  Add Synaptics touchpad tweaking to psmouse driver

resurrect-batch_requests.patch
  bring back the batch_requests function

kblockd.patch
  Create `kblockd' workqueue

cfq-infrastructure.patch

elevator-completion-api.patch
  elevator completion API

as-iosched.patch
  anticipatory I/O scheduler

as-proc-read-write.patch
  AS: pgbench improvement

as-discrete-read-fifo-batches.patch
  AS: discrete read fifo batches

as-sync-async.patch
  AS sync/async batches

as-hash-removal-fix.patch
  AS: hash removal fix

as-jumbo-patch-for-scsi.patch
  AS jumbo patch (for SCSI and TCQ)

as-stupid.patch
  AS: fix stupid thinko

as-no-batch-antic-limit.patch
  AS: no batch-antic-limit

unplug-use-kblockd.patch
  Use kblockd for running request queues

cfq-2.patch
  CFQ scheduler, #2
  CFQ: update to rq-dyn API

cfq-hash-removal-fix.patch
  CFQ: hash removal fix

cfq-list_del-fix.patch
  CFQ: empty the queuelist

per-queue-nr_requests.patch
  per queue nr_requests

blk-invert-watermarks.patch
  blk_congestion_wait threshold cleanup

blk-fair-batches.patch
  blk-fair-batches

blk-as-hint.patch
  blk-as-hint

get_request_wait-oom-fix.patch
  handle OOM in get_request_wait().

unmap-page-debugging-2.patch
  debug patch: unmap unused kernel pages

unmap-page-debugging-2-fix.patch

slab-poisoning-fix.patch
  slab poisoning fix

print-build-options-on-oops.patch
  print a few config options on oops

mmap-prefault.patch
  prefault of executable mmaps

dac960-negotiation-fix.patch
  DAC960 fix for fibre channel transfer rate

bio-debug-trap.patch
  BIO debugging patch

sound-irq-hack.patch

show_task-free-stack-fix.patch
  show_task() fix and cleanup

put_task_struct-debug.patch

ia32-mknod64.patch
  mknod64 for ia32

ext2-64-bit-special-inodes.patch
  ext2: support for 64-bit device nodes

ext3-64-bit-special-inodes.patch
  ext3: support for 64-bit device nodes

64-bit-dev_t-kdev_t.patch
  64-bit dev_t and kdev_t

oops-dump-preceding-code.patch
  i386 oops output: dump preceding code

lockmeter.patch

ext3-no-bkl.patch

journal_get_write_access-speedup.patch
  JBD: journal_get_write_access() speedup

ext3-concurrent-block-inode-allocation.patch
  ext3: concurrent block/inode allocation
  Fix orlov allocator boundary case

ext3-concurrent-block-allocation-hashed.patch
  ext3: scalable counters and locks
  fix ext3 inode allocator race

jbd-010-b_committed_data-race-fix.patch
  JBD: fix race over access to b_committed_data

jbd-020-locking-schema.patch
  JBD: plan JBD locking schema

jbd-030-remove-splice_lock.patch
  JBD: remove jh_splice_lock

jbd-040-journal_add_journal_head-locking.patch
  JBD: fine-grain journal_add_journal_head locking

jbd-045-rename-journal_unlock_journal_head.patch
  JBD: rename journal_unlock_journal_head to journal_put_journal_head

jbd-050-b_frozen_data-locking.patch
  JBD: Finish protection of journal_head.b_frozen_data

jbd-060-b_committed_data-locking.patch
  JBD: implement b_committed_data locking

jbd-070-b_transaction-locking.patch
  JBD: implement b_transaction locking rules

jbd-080-b_next_transaction-locking.patch
  JBD: Implement b_next_transaction locking rules

jbd-090-b_tnext-locking.patch
  JBD: b_tnext locking

jbd-100-remove-journal_datalist_lock.patch
  JBD: remove journal_datalist_lock

jbd-110-t_nr_buffers-locking.patch
  JBD: t_nr_buffers locking

jbd-120-t_updates-locking.patch
  JBD: t_updates locking

jbd-130-t_outstanding_credits-locking.patch
  JBD: implement t_outstanding_credits locking

jbd-140-t_jcb-locking.patch
  JBD: implement t_jcb locking

jbd-150-j_barrier_count-locking.patch
  JBD: implement j_barrier_count locking

jbd-160-j_running_transaction-locking.patch
  JBD: implement j_running_transaction locking

jbd-170-j_committing_transaction-locking.patch
  JBD: implement j_committing_transaction locking

jbd-180-j_checkpoint_transactions.patch
  JBD: implement j_checkpoint_transactions locking

jbd-190-j_head-locking.patch
  JBD: implement journal->j_head locking

jbd-200-j_tail-locking.patch
  JBD: implement journal->j_tail locking

jbd-210-j_free-locking.patch
  JBD: implement journal->j_free locking

jbd-220-j_commit_sequence-locking.patch
  JBD: implement journal->j_commit_sequence locking

jbd-230-j_commit_request-locking.patch
  JBD: implement j_commit_request locking

jbd-240-dual-revoke-tables.patch
  JBD: implement dual revoke tables.

jbd-250-remove-sleep_on.patch
  JBD: remove remaining sleep_on()s

jbd-300-remove-lock_kernel.patch
  JBD: remove lock_kernel()

jbd-400-remove-lock_journal.patch
  JBD: remove lock_journal()

jbd-510-h_credits-fix.patch
  JBD: journal_release_buffer: handle credits fix

jbd-520-journal_unmap_buffer-race.patch
  JBD: journal_unmap_buffer race fix

jbd-530-walk_page_buffers-race-fix.patch
  ext3: ext3_writepage race fix

jbd-540-journal_try_to_free_buffers-race-fix.patch
  JBD: buffer freeing non-race comment

jbd-550-locking-checks.patch
  JBD: add some locking assertions

jbd-570-transaction-state-locking.patch
  JBD: additional transaction shutdown locking

jbd-580-log_start_commit-race-fix.patch
  JBD: fix log_start_commit race

jbd-590-do_get_write_access-speedup.patch
  JBD: do_get_write_access() speedup

ext3-010-fix-journalled-data.patch
  ext3: fix data=journal mode

ext3-035-journal_try_to_free_buffers-race-fix.patch

ext3-040-recursive-ext3_write_inode-check.patch
  ext3: add a dump_stack()

ext3-050-ioctl-transaction-leak.patch
  ext3: fix error-path handle leak

ext3-070-xattr-clone-leak-fix.patch
  Fix leak in ext3_acl_chmod()

ext3-080-remove-block-inode-count-message.patch
  ext3: remove mount-time diagnostic messages

jbd-600-journal_dirty_metadata-speedup.patch
  JBD: journal_dirty_metadata() speedup

jbd-610-journal_dirty_metadata-diags.patch
  JBD: journal_dirty_metadata diagnostics

jbd-620-commit-vs-start-race-fix.patch
  JBD: fix race between journal_commit_transaction and start_this_handle

invalidate_mmap_range.patch
  Interface to invalidate regions of mmaps

aio-01-retry.patch
  AIO: Core retry infrastructure

aio-02-lockpage_wq.patch
  AIO: Async page wait

aio-03-fs_read.patch
  AIO: Filesystem aio read

aio-04-buffer_wq.patch
  AIO: Async buffer wait

aio-05-fs_write.patch
  AIO: Filesystem aio write

aio-05-fs_write-fix.patch

aio-06-bread_wq.patch
  AIO: Async block read

aio-06-bread_wq-fix.patch

aio-07-ext2getblk_wq.patch
  AIO: Async get block for ext2

aio-poll.patch
  aio_poll
  aio-poll: don't put extern decls in .c!

O_SYNC-speedup-2.patch
  speed up O_SYNC writes

aio-09-o_sync.patch
  aio O_SYNC

vfsmount_lock.patch
  From: Maneesh Soni <maneesh@in.ibm.com>
  Subject: [patch 1/2] vfsmount_lock

syncppp-locking-fix.patch
  syncppp locking fix

s390-dirty-bit-cleaning.patch
  dirty bit clearing on s390.

min_free_kbytes.patch
  /proc/sys/vm/min_free_kbytes

sched-hot-balancing-fix.patch
  fix for CPU scheduler load distribution




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.5.70-mm5 new oops that wasn't in 2.5.70-mm4
  2003-06-05  9:12 2.5.70-mm5 Andrew Morton
@ 2003-06-05 11:57 ` Helge Hafting
  2003-06-05 12:35   ` Paul E. Erkkila
  2003-06-05 14:05 ` 2.5.70-mm5 Pavel Machek
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Helge Hafting @ 2003-06-05 11:57 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, linux-mm, neilb

mm5 has a raid-1-related boot oops that wasn't in mm4.
Unlike my earlier reports this was a single oops, not
a string of them.

This is an UP machine with / on raid-1, no raid-0.
The kernel is monolithic and compiled with gcc 3.3

The last boot message before the crash was
md: ... autorun DONE.
The next one is normally
VFS: Mounted root (ext2 filesystem) readonly.
So I guess this failed.

Here is the oops, written down form a framebuffer using
the 4x6 font (urgh...)

unable to handle kernel paging request at 6b6b6b97 (poison?)
PREEMP DEBUG_PAGEALLOC not tainted
EIP: put_all_bios
process swapper
trace:
raid_end_bio_io
raid1_end_request
kernel_map_pages
mempool_free
bio_endio
_end_that_request_first
ide_end_request
ide_dma_intr
ide_intr
handle_IRQ_event
do_IRQ
default_idle
common_interrupt
default_idle
default_idle
cpu_idle
rest_init
start_kernel
unknown_bootoption

This is 2.5.70-mm5 without other patches.


Helge Hafting



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.5.70-mm5 new oops that wasn't in 2.5.70-mm4
  2003-06-05 11:57 ` 2.5.70-mm5 new oops that wasn't in 2.5.70-mm4 Helge Hafting
@ 2003-06-05 12:35   ` Paul E. Erkkila
  0 siblings, 0 replies; 6+ messages in thread
From: Paul E. Erkkila @ 2003-06-05 12:35 UTC (permalink / raw)
  To: Helge Hafting; +Cc: Andrew Morton, linux-kernel, linux-mm, neilb

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

This same oops exists in a normal kernel from
bitkeeper with a patch (raid 0 though..) from
Neil Brown applied.(I think it was the same one in -mm).
I am also running / as a raid-1 partition.

-pee



[-- Attachment #2: ksym.raid1 --]
[-- Type: text/plain, Size: 3591 bytes --]

ksymoops 2.4.9 on i686 2.5.69.  Options used
     -v vmlinux (specified)
     -k /proc/ksyms (default)
     -l /proc/modules (default)
     -o /lib/modules/2.5.69/ (default)
     -m System.map (specified)

Error (regular_file): read_ksyms stat /proc/ksyms failed
No modules in ksyms, skipping objects
No ksyms, skipping lsmod
kernbel BUG at drivers/md/raid1.c:145!
invalid operand: 000 [#1]
CPU:   0
EIP:   0060:[<c025d7df>]   Not tainted
Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010097
eax: 00000000 ebx: 00000001 exc: 00000010 edx: f7ffb800
Warning (Oops_set_regs): garbage 'exc: 00000010 edx: f7ffb800' at end of register line ignored
esi: f7d5ddb4 edi: 00000003 ebp: c036bdf8 esp: c036bde8
ds: 007 es: 007b ss:0068
Stack: f7fcf900 f7d80480 00000046 f7d5dd80 c036be18 c025d8fc f7d80480
f7d4dd80
      00000000 f7d5dd80 00000001 0000000c c036be18 c025da43 f7d5dd80
f7f9f880
      00000003 00000000 00000001 00000004 00000000 c18f5ch4 f7d6fce0
0000000c
Call Trace:
[<c025d8fc>] raid_end_bio_io+0x55/0x92
[<c025da43>] raid1_end_request+0x10a/0x196
[<c013042c>] mempool_free+0x32/0x65
[<c014a420>] bio_endio+0x55/0x7a
[<c01ef559>] __end_that_request_first+0x1f1/0x20d
[<c023c0a4>] ide_end_request+0x58/0x118
[<c024f3cb>] ide_dma_intr+0x9d/0xba
[<c023d43f>] ide_intr+0xb9/0x12e
[<c024f34e>] ide_dma_intr+0x0/0xba
[<c010c279>] handle_IRQ_event+0x3c/0xfd
[<c010c48f>] do_IRQ+0x80/0xd6
[<c0108be9>] default_idle+0x0/0x2c
[<c0108be9>] default_idle+0x0/0x2c
[<c010acd4>] common_interrupt+0x18/0x20
[<c0108be9>] default_idle+0x0/0x2c
[<c0108be9>] default_idle+0x0/0x2c
[<c0108c10>] default_idle+0x27/0x2c
[<c0108c81>] cpu_idle+0x31/0x3a
[<c0105000>] _stext+0x0/0x2a
[<c036c678>] start_kernel+0x152/0x177
[<c036c401>] unknown_bootoption+0x0/0xfa
Code: 0f 0b 91 00 85 96 2d c0 89 14 24 e8 7e c2 ee ff c7 06 00 00


>>EIP; c025d7df <put_all_bios+59/85>   <=====

>>esi; f7d5ddb4 <_end+3797c660/3fc1c8ac>
>>ebp; c036bdf8 <init_thread_union+1df8/2000>
>>esp; c036bde8 <init_thread_union+1de8/2000>

Trace; c025d8fc <raid_end_bio_io+55/92>
Trace; c025da43 <raid1_end_request+10a/196>
Trace; c013042c <mempool_free+32/65>
Trace; c014a420 <bio_endio+55/7a>
Trace; c01ef559 <__end_that_request_first+1f1/20d>
Trace; c023c0a4 <ide_end_request+58/118>
Trace; c024f3cb <ide_dma_intr+9d/ba>
Trace; c023d43f <ide_intr+c3/12e>
Trace; c024f34e <ide_dma_intr+20/ba>
Trace; c010c279 <handle_IRQ_event+3c/fd>
Trace; c010c48f <do_IRQ+80/d6>
Trace; c0108be9 <default_idle+0/2c>
Trace; c0108be9 <default_idle+0/2c>
Trace; c010acd4 <common_interrupt+18/20>
Trace; c0108be9 <default_idle+0/2c>
Trace; c0108be9 <default_idle+0/2c>
Trace; c0108c10 <default_idle+27/2c>
Trace; c0108c81 <cpu_idle+31/3a>
Trace; c0105000 <_stext+0/0>
Trace; c036c678 <start_kernel+152/177>
Trace; c036c401 <unknown_bootoption+0/fa>

Code;  c025d7df <put_all_bios+59/85>
00000000 <_EIP>:
Code;  c025d7df <put_all_bios+59/85>   <=====
   0:   0f 0b                     ud2a      <=====
Code;  c025d7e1 <put_all_bios+5b/85>
   2:   91                        xchg   %eax,%ecx
Code;  c025d7e2 <put_all_bios+5c/85>
   3:   00 85 96 2d c0 89         add    %al,0x89c02d96(%ebp)
Code;  c025d7e8 <put_all_bios+62/85>
   9:   14 24                     adc    $0x24,%al
Code;  c025d7ea <put_all_bios+64/85>
   b:   e8 7e c2 ee ff            call   ffeec28e <_EIP+0xffeec28e>
Code;  c025d7ef <put_all_bios+69/85>
  10:   c7 06 00 00 00 00         movl   $0x0,(%esi)

<0>Kernel panic: Fatal exception in interrupt
> unable to handle kernel paging request at 6b6b6b97 (poison?)

1 warning and 1 error issued.  Results may not be reliable.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.5.70-mm5
  2003-06-05  9:12 2.5.70-mm5 Andrew Morton
  2003-06-05 11:57 ` 2.5.70-mm5 new oops that wasn't in 2.5.70-mm4 Helge Hafting
@ 2003-06-05 14:05 ` Pavel Machek
  2003-06-07 10:08 ` 2.5.70-mm5: sound/pcmcia/vx/snd-vx* multiple definitions Adrian Bunk
  2003-06-07 13:41 ` [patch] 2.5.70-mm5: Compile error if !CONFIG_PROC_FS Adrian Bunk
  3 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2003-06-05 14:05 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, linux-mm

Hi!

> common-ioctl32.patch
>   From: Pavel Machek <pavel@suse.cz>
>   Subject: Re: must-fix list, v5

Any chance to push this to Linus? Or
should I start pushing again?
				Pavel

-- 
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...


^ permalink raw reply	[flat|nested] 6+ messages in thread

* 2.5.70-mm5: sound/pcmcia/vx/snd-vx* multiple definitions
  2003-06-05  9:12 2.5.70-mm5 Andrew Morton
  2003-06-05 11:57 ` 2.5.70-mm5 new oops that wasn't in 2.5.70-mm4 Helge Hafting
  2003-06-05 14:05 ` 2.5.70-mm5 Pavel Machek
@ 2003-06-07 10:08 ` Adrian Bunk
  2003-06-07 13:41 ` [patch] 2.5.70-mm5: Compile error if !CONFIG_PROC_FS Adrian Bunk
  3 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2003-06-07 10:08 UTC (permalink / raw)
  To: Andrew Morton, perex, alsa-devel; +Cc: linux-kernel

It seems the following compile error comes from Linus' tree:

<--  snip  -->

...
  LD      sound/pcmcia/vx/snd-vxpocket.o
  LD      sound/pcmcia/vx/snd-vxp440.o
  LD      sound/pcmcia/vx/built-in.o
sound/pcmcia/vx/snd-vxp440.o(.text+0x160): In function 
`snd_vxpocket_attach':
: multiple definition of `snd_vxpocket_attach'
sound/pcmcia/vx/snd-vxpocket.o(.text+0x160): first defined here
sound/pcmcia/vx/snd-vxp440.o(.data+0x1a0): multiple definition of 
`snd_vxpocket_ops'
sound/pcmcia/vx/snd-vxpocket.o(.data+0x1a0): first defined here
sound/pcmcia/vx/snd-vxp440.o(.text+0x420): In function 
`snd_vxpocket_detach':
: multiple definition of `snd_vxpocket_detach'
sound/pcmcia/vx/snd-vxpocket.o(.text+0x420): first defined here
sound/pcmcia/vx/snd-vxp440.o(.text+0x1320): In function 
`vx_set_mic_boost':
: multiple definition of `vx_set_mic_boost'
sound/pcmcia/vx/snd-vxpocket.o(.text+0x1320): first defined here
sound/pcmcia/vx/snd-vxp440.o(.text+0x4e0): In function 
`snd_vxpocket_detach_all':
: multiple definition of `snd_vxpocket_detach_all'
sound/pcmcia/vx/snd-vxpocket.o(.text+0x4e0): first defined here
sound/pcmcia/vx/snd-vxp440.o(.text+0x1a60): In function 
`vxp_add_mic_controls':
: multiple definition of `vxp_add_mic_controls'
sound/pcmcia/vx/snd-vxpocket.o(.text+0x1a60): first defined here
sound/pcmcia/vx/snd-vxp440.o(.text+0x14e0): In function 
`vx_set_mic_level':
: multiple definition of `vx_set_mic_level'
sound/pcmcia/vx/snd-vxpocket.o(.text+0x14e0): first defined here
make[3]: *** [sound/pcmcia/vx/built-in.o] Error 1

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [patch] 2.5.70-mm5: Compile error if !CONFIG_PROC_FS
  2003-06-05  9:12 2.5.70-mm5 Andrew Morton
                   ` (2 preceding siblings ...)
  2003-06-07 10:08 ` 2.5.70-mm5: sound/pcmcia/vx/snd-vx* multiple definitions Adrian Bunk
@ 2003-06-07 13:41 ` Adrian Bunk
  3 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2003-06-07 13:41 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, trivial

It seems the following compile error if !CONFIG_PROC_FS comes from 
Linus' tree:

<--  snip  -->

...
  CC      init/main.o
In file included from init/main.c:15:
include/linux/proc_fs.h:238: redefinition of `kclist_add'
include/linux/proc_fs.h:231: `kclist_add' previously defined here
include/linux/proc_fs.h:239: redefinition of `kclist_del'
include/linux/proc_fs.h:234: `kclist_del' previously defined here
include/linux/proc_fs.h: In function `kclist_del':
include/linux/proc_fs.h:239: syntax error before '}' token
include/linux/proc_fs.h:239: warning: no return statement in function 
returning non-void
make[1]: *** [init/main.o] Error 1

<--  snip  -->


The fis is trivial:


--- linux-2.5.70-mm5/include/linux/proc_fs.h.old	2003-06-07 15:33:21.000000000 +0200
+++ linux-2.5.70-mm5/include/linux/proc_fs.h	2003-06-07 15:34:04.000000000 +0200
@@ -235,8 +235,6 @@
 	return NULL;
 }
 
-static inline void kclist_add(struct kcore_list *new, void *addr, size_t size) {};
-static inline struct kcore_list * kclist_del(void *addr) {return NULL};
 #endif /* CONFIG_PROC_FS */
 
 struct proc_inode {




cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2003-06-07 13:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-05  9:12 2.5.70-mm5 Andrew Morton
2003-06-05 11:57 ` 2.5.70-mm5 new oops that wasn't in 2.5.70-mm4 Helge Hafting
2003-06-05 12:35   ` Paul E. Erkkila
2003-06-05 14:05 ` 2.5.70-mm5 Pavel Machek
2003-06-07 10:08 ` 2.5.70-mm5: sound/pcmcia/vx/snd-vx* multiple definitions Adrian Bunk
2003-06-07 13:41 ` [patch] 2.5.70-mm5: Compile error if !CONFIG_PROC_FS Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).