Re: Coding standards. (Was: Re: [PATCH] [2.5] Non-blocking write can block)

From: Timothy Miller <miller@techsource.com>
To: Greg KH <greg@kroah.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Coding standards.  (Was: Re: [PATCH] [2.5] Non-blocking write can block)
Date: Mon, 09 Jun 2003 12:24:35 -0400	[thread overview]
Message-ID: <3EE4B4C3.80902@techsource.com> (raw)
In-Reply-To: 20030607001202.GB14475@kroah.com

Greg KH wrote:
> On Wed, Jun 04, 2003 at 11:21:41AM -0400, Timothy Miller wrote:
> 
>>Perhaps it would be good to have an explanation for the relative 
>>importance of placing braces and else on the same line as compared to 
>>other formatting standards.
> 
> 
> Please read Documentation/CodingStyle.
> 
> If you want more justification, read my OLS 2001 paper.
> 

Well, the coding style you propose isn't exactly the way I do things 
(although it's pretty close).  For instance, I'm not accustomed to using 
a single tab character for indent.  Having more experience with X11 
internals than Linux, you can see where I would get my four-space indent 
habit from.  No matter.  I can easily adapt.

One thing I wanted to mention, however, is that your tongue-in-cheek 
style doesn't help you.  Coding style is something that needs to be 
taken seriously when you're setting standards.