From: Paul Cercueil <paul@crapouillou.net>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Simon Ser <contact@emersion.fr>
Cc: Sam Ravnborg <sam@ravnborg.org>,
od@zcrc.me, linux-mips@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/ingenic: Don't request full modeset if property is not modified
Date: Mon, 12 Apr 2021 15:32:27 +0100 [thread overview]
Message-ID: <3EGGRQ.5XC2ZJHIFWID@crapouillou.net> (raw)
In-Reply-To: <20210329175046.214629-3-paul@crapouillou.net>
Can I have an ACK for this patch?
Cheers,
-Paul
Le lun. 29 mars 2021 à 18:50, Paul Cercueil <paul@crapouillou.net> a
écrit :
> Avoid requesting a full modeset if the sharpness property is not
> modified, because then we don't actually need it.
>
> Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU")
> Cc: <stable@vger.kernel.org> # 5.8+
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/gpu/drm/ingenic/ingenic-ipu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c
> b/drivers/gpu/drm/ingenic/ingenic-ipu.c
> index 3b1091e7c0cd..95b665c4a7b0 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c
> @@ -640,10 +640,12 @@ ingenic_ipu_plane_atomic_set_property(struct
> drm_plane *plane,
> {
> struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
> struct drm_crtc_state *crtc_state;
> + bool mode_changed;
>
> if (property != ipu->sharpness_prop)
> return -EINVAL;
>
> + mode_changed = val != ipu->sharpness;
> ipu->sharpness = val;
>
> if (state->crtc) {
> @@ -651,7 +653,7 @@ ingenic_ipu_plane_atomic_set_property(struct
> drm_plane *plane,
> if (WARN_ON(!crtc_state))
> return -EINVAL;
>
> - crtc_state->mode_changed = true;
> + crtc_state->mode_changed |= mode_changed;
> }
>
> return 0;
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-04-12 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 17:50 [PATCH 0/2] drm/ingenic: IPU plane fixes Paul Cercueil
2021-03-29 17:50 ` [PATCH 1/2] drm/ingenic: Switch IPU plane to type OVERLAY Paul Cercueil
2021-03-30 7:23 ` Simon Ser
2021-03-30 11:53 ` Paul Cercueil
2021-03-30 12:59 ` Simon Ser
2021-03-29 17:50 ` [PATCH 2/2] drm/ingenic: Don't request full modeset if property is not modified Paul Cercueil
2021-04-12 14:32 ` Paul Cercueil [this message]
2021-04-15 9:26 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EGGRQ.5XC2ZJHIFWID@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@linux.ie \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=od@zcrc.me \
--cc=sam@ravnborg.org \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).