From: "David D. Hagood" <wowbagger@sktc.net>
To: hzhong@cisco.com
Cc: "'Alan Stern'" <stern@rowland.harvard.edu>, linux-kernel@vger.kernel.org
Subject: Re: Style question: Should one check for NULL pointers?
Date: Fri, 11 Jul 2003 09:13:03 -0500 [thread overview]
Message-ID: <3F0EC5EF.7090002@sktc.net> (raw)
In-Reply-To: <01c701c34766$4706cc50$743147ab@amer.cisco.com>
Hua Zhong wrote:
> Not always true. In some cases you know how to handle: just return
> without doing anyting.
That is NOT an error condition - the API specifically allows NULL to be
passed in, and specifically states that no action will be taken in that
case.
But consider the following code:
sscanf(0,0);
That IS an error condition - both the string to scan and the format
string are NULL. In this case sscanf should return EITHER 0 (no items
matched) or better still -1 (error).
As others have said - ideally, if you have any doubt about a new
function you are writing being able to succeed, you should write it to
return a success report.
However, my whole point was that simply checking for null and doing
nothing when null was not a valid value was violating the rule of "don't
check if you don't know how to handle".
next prev parent reply other threads:[~2003-07-11 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-10 20:28 Style question: Should one check for NULL pointers? Alan Stern
2003-07-10 20:52 ` Eli Carter
2003-07-10 22:12 ` H. Peter Anvin
2003-07-11 2:35 ` Alan Stern
2003-07-11 14:29 ` Eli Carter
2003-07-11 15:16 ` Alan Stern
2003-07-12 18:40 ` Horst von Brand
2003-07-13 21:42 ` Alan Stern
2003-07-11 20:33 ` H. Peter Anvin
2003-07-10 22:54 ` David D. Hagood
2003-07-11 4:02 ` Hollis Blanchard
2003-07-11 4:38 ` Hua Zhong
2003-07-11 14:13 ` David D. Hagood [this message]
2003-07-11 14:52 ` Richard B. Johnson
2003-07-11 15:39 ` Alan Stern
2003-07-11 19:32 ` Horst von Brand
2003-07-11 20:36 ` H. Peter Anvin
2003-07-11 21:21 ` Alan Stern
2003-07-13 22:53 ` Ingo Oeser
[not found] <7QmZ.5RP.17@gated-at.bofh.it>
2003-07-10 21:00 ` Dennis Bliefernicht
2003-07-10 22:13 ` H. Peter Anvin
2003-07-10 22:28 ` Larry McVoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0EC5EF.7090002@sktc.net \
--to=wowbagger@sktc.net \
--cc=hzhong@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).