linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Thomas Schlichter <schlicht@uni-mannheim.de>
Cc: ricardo.b@zmail.pt, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@redhat.com>
Subject: Re: SET_MODULE_OWNER
Date: Thu, 17 Jul 2003 12:00:58 -0400	[thread overview]
Message-ID: <3F16C83A.2010303@pobox.com> (raw)
In-Reply-To: <200307171756.19826.schlicht@uni-mannheim.de>

Thomas Schlichter wrote:
> On Thursday 17 July 2003 17:32, Jeff Garzik wrote:
> 
>>Ricardo Bugalho wrote:
>>
>>>Hi all,
>>>  most net device drivers have replaced MOD_INC/DEC_USE_COUNT with
>>>SET_MODULE_OWNER but SET_MODULE_OWNER doesn't do nothing.
>>>  Therefore, those modules (though I can only vouch for 8139too) always
>>>report 0 use. Some people that had "modprobe -r" in their cronttab found
>>>it quite annoying.
>>>  I'd guess that there's a good reason for why struct net_device doesn't
>>>have .owner field and why this happens. Can someone be so kind to point
>>>it
>>>out?
>>
>>struct net_device does have an owner field, and SET_MODULE_OWNER
>>obviously _does_ do something.
> 
> 
> That's not correct for 2.5.x anymore...
> Have a look at Changeset 1.1167 from davem.
> 
> It removed the owner field about 9 weeks ago. That was the time where 
> SET_MODULE_OWNER became a NOP...
> 
> 
>>If your interface is up, your net driver's module refcount is greater
>>than zero.
> 
> 
> Well, as I looked now my netdevice is up, but its reference count is at 0, 
> too!

Doh.  I missed that.

David?  Does Rusty have a plan here or something?

	Jeff




  reply	other threads:[~2003-07-17 15:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-17 12:56 SET_MODULE_OWNER Ricardo Bugalho
2003-07-17 15:32 ` SET_MODULE_OWNER Jeff Garzik
2003-07-17 15:56   ` SET_MODULE_OWNER Thomas Schlichter
2003-07-17 16:00     ` Jeff Garzik [this message]
2003-07-17 19:59       ` SET_MODULE_OWNER David S. Miller
2003-07-17 20:22         ` SET_MODULE_OWNER Jeff Garzik
2003-07-17 20:19           ` SET_MODULE_OWNER David S. Miller
2003-07-17 20:48             ` SET_MODULE_OWNER Jeff Garzik
2003-07-17 21:34               ` SET_MODULE_OWNER David S. Miller
2003-07-18  9:48             ` SET_MODULE_OWNER Roman Zippel
2003-07-18  7:31           ` SET_MODULE_OWNER Duncan Sands
2003-07-18  9:05             ` SET_MODULE_OWNER Martin Diehl
2003-07-18 10:12               ` SET_MODULE_OWNER Duncan Sands
2003-07-18 12:46                 ` SET_MODULE_OWNER Martin Diehl
2003-07-17 21:36         ` SET_MODULE_OWNER Ricardo Bugalho
2003-07-17 21:40           ` SET_MODULE_OWNER David S. Miller
2003-07-17 22:23             ` SET_MODULE_OWNER Ricardo Bugalho
2003-07-17 22:16               ` SET_MODULE_OWNER David S. Miller
2003-07-18  0:49                 ` SET_MODULE_OWNER Ricardo Bugalho
2003-07-18  2:27             ` SET_MODULE_OWNER James H. Cloos Jr.
2003-07-18  5:26               ` SET_MODULE_OWNER David S. Miller
2003-07-20  2:10                 ` SET_MODULE_OWNER James H. Cloos Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F16C83A.2010303@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricardo.b@zmail.pt \
    --cc=schlicht@uni-mannheim.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).