From: "Ihar \"Philips\" Filipau" <filia@softhome.net> To: linux-kernel@vger.kernel.org Subject: Re: [uClinux-dev] Kernel 2.6 size increase - get_current()? Date: Thu, 24 Jul 2003 10:13:37 +0200 [thread overview] Message-ID: <3F1F9531.2050204@softhome.net> (raw) In-Reply-To: <cArg.74D.11@gated-at.bofh.it> Bernardo Innocenti wrote: > On Wednesday 23 July 2003 22:27, Christoph Hellwig wrote: > >>On Wed, Jul 23, 2003 at 01:22:56PM -0700, David S. Miller wrote: >>>Drivers weren't audited much, and there's a lot of boneheaded >>>stuff in this area. But these should be mostly identical >>>to what would happen on the 2.4.x side >> >>Please read the original message again - he stated that every single >>module in fs/ got alot bigger - if it gets smaller or at least the >>same size as 2.4 it's clearly a sign of inlines gone mad in the >>filesystem/VM code and we need to look at that. If not we have to look >>elsewhere. > > I have my humbling opinion: > > In 2.4.20 (m68knommu): > ------------------------------------------------------------------------- > #define current _current_task > ------------------------------------------------------------------------- > > In 2.6.0-test1 (m68knommu): > ------------------------------------------------------------------------- > static inline struct task_struct *get_current(void) > { [cut] > } > static inline struct thread_info *current_thread_info(void) > { [cut] > } > ------------------------------------------------------------------------- > > This takes 18*11 = 198 bytes just for invoking the 'current' > macro so many times. > Just curious. Is there any way to guess inline from inline? I mean 'inline' which means 'this has to be inlined or it will break' and 'inline' which means 'inline this please - it adds only 10k of code bloat and improve performance in my suppa-puppa-bench by 0.000001%!' Strictly speaking - separate 'inline' to 'require_inline' and 'better_inline'. So people who really care about image size - can turn 'better_inline' into void, without harm to functionality. Actually I saw real performance improvements on my Pentium MMX 133 (it has $i16k+$d16k of caches I beleive) when I was cutting some of inlines out. and I'm not talking about (cache poor) embedded systems...
next parent reply other threads:[~2003-07-24 7:57 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <cwQJ.3BO.29@gated-at.bofh.it> [not found] ` <cypH.5dM.35@gated-at.bofh.it> [not found] ` <cyza.5lN.13@gated-at.bofh.it> [not found] ` <cArg.74D.11@gated-at.bofh.it> 2003-07-24 8:13 ` Ihar "Philips" Filipau [this message] 2003-07-25 7:25 ` Denis Vlasenko 2003-07-25 18:36 ` bill davidsen [not found] <d2nx.4QV.15@gated-at.bofh.it> [not found] ` <dbTZ.5Z5.19@gated-at.bofh.it> 2003-07-25 15:37 ` Ihar "Philips" Filipau 2003-07-24 8:27 Ihar "Philips" Filipau 2003-07-24 11:50 ` David McCullough -- strict thread matches above, loose matches on Subject: below -- 2003-07-23 18:46 Kernel 2.6 size increase Bernardo Innocenti 2003-07-23 20:22 ` [uClinux-dev] " David S. Miller 2003-07-23 20:27 ` Christoph Hellwig 2003-07-23 22:35 ` [uClinux-dev] Kernel 2.6 size increase - get_current()? Bernardo Innocenti 2003-07-23 22:37 ` Alan Cox 2003-07-23 23:00 ` Bernardo Innocenti 2003-07-24 5:06 ` David McCullough 2003-07-24 11:28 ` Alan Cox 2003-07-24 12:04 ` David McCullough 2003-07-24 14:48 ` Alan Cox 2003-07-25 18:25 ` bill davidsen 2003-07-24 15:30 ` Hollis Blanchard 2003-07-24 19:37 ` Alan Cox 2003-07-24 19:51 ` Hollis Blanchard 2003-07-24 21:20 ` J.A. Magallon 2003-07-25 4:22 ` Otto Solares 2003-07-25 14:38 ` Hollis Blanchard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3F1F9531.2050204@softhome.net \ --to=filia@softhome.net \ --cc=linux-kernel@vger.kernel.org \ --subject='Re: [uClinux-dev] Kernel 2.6 size increase - get_current()?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).