From: John Belmonte <jvb@prairienet.org>
To: "Ben Collins" <bcollins@debian.org>,
"Linus Torvalds" <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net,
"Michael Wawrzyniak" <gan@planetlaz.com>
Subject: [PATCH] bad strlcpy conversion breaks toshiba_acpi
Date: Fri, 25 Jul 2003 10:46:38 -0400 [thread overview]
Message-ID: <3F2142CE.4090608@prairienet.org> (raw)
Please revert the following item from Ben Collins' "drivers/* strlcpy
conversions" patch dated 2003-May-26.
The strlcpy function requires a zero-terminated string, which is not a
valid assumption for the code in question. I suggest that Ben review
all such modifications he made to the kernel for similar errors. It's
quite annoying to have someone add bugs to your driver while you're not
looking. Either notify the maintainer of your patch or don't make mistakes.
Another gripe I have is that bitkeeper user "bcollins" does not have a
valid email address.
-John Belmonte
Item to be REVERTED:
--- 1.9/drivers/acpi/toshiba_acpi.c Mon May 19 10:57:16 2003
+++ 1.10/drivers/acpi/toshiba_acpi.c Sun May 25 17:00:00 2003
@@ -108,8 +108,7 @@
int result;
char* str2 = kmalloc(n + 1, GFP_KERNEL);
if (str2 == 0) return 0;
- strncpy(str2, str, n);
- str2[n] = 0;
+ strlcpy(str2, str, n);
va_start(args, format);
result = vsscanf(str2, format, args);
va_end(args);
References:
http://www.ussg.iu.edu/hypermail/linux/kernel/0305.3/0267.html
http://linux-acpi.bkbits.net:8080/linux-acpi/diffs/drivers/acpi/toshiba_acpi.c@1.10?nav=index.html|src/|src/drivers|src/drivers/acpi|hist/drivers/acpi/toshiba_acpi.c
--
http:// if l .o /
next reply other threads:[~2003-07-25 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-25 14:46 John Belmonte [this message]
2003-07-25 16:15 ` [PATCH] bad strlcpy conversion breaks toshiba_acpi Petr Vandrovec
2003-07-25 16:57 ` Andries Brouwer
2003-07-27 21:02 ` [ACPI] " Matthew Wilcox
2003-07-27 21:26 ` M. Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F2142CE.4090608@prairienet.org \
--to=jvb@prairienet.org \
--cc=acpi-devel@lists.sourceforge.net \
--cc=bcollins@debian.org \
--cc=gan@planetlaz.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).