archive mirror
 help / color / mirror / Atom feed
From: Carsten Otto <>
Subject: e1000 statistics timer
Date: Sat, 02 Aug 2003 21:45:03 +0200	[thread overview]
Message-ID: <> (raw)

I own two Intel Gigabit cards running with the e1000 driver.
The only problem is the statistics for ifconfig (RX bytes, TX bytes) and 
for other programs like gkrellm, bwmon, ... are only updated every _two_ 
This results in a strange display. When the real traffic is at constant 
10MB/sec every program displays:
"0 - 20MB/sec - 0 - 20MB/sec - ..."
So, every two seconds the total of the last two seconds. Between that 
just nothing.

After a while I got too annoyed and tried to change that.
In e1000_main.c you can find the line (number 1424):

"mod_timer(&adapter->watchdog_timer, jiffies + 2* HZ);"

I don't really understand driver programming, but HZ is 100 and means 1 
Changing this line to "... + 1* HZ" resulted  in a better behaviour. I 
got "a - b - c - d - 0 - e - f  - g - h - 0 - ..." where the letters are 
quite correct numbers, every fifth value is zero.
The next step was deleting these "jiffies" (what are these?).
Final result:

"mod_timer(&adapter->watchdog_timer, HZ);"

With this line (and the new kernel of course) I get everything what I 
need. All programs display the bandwith like they do with my other NICs.

Now my questions:
1) Is my implementation right? It works...
2) Can I change that delay to 1 sec withhout "hurting someone"?
3) What are these jiffies? Mathematically they are about 20 :>
4) There are other timers in the code, that use "jiffies + 2 * HZ" too. 
Should they  be changed, too?

Please answer to, because I don't get the whole LKML.

Carsten Otto

My kernel is 2.4.20 wolk4.2s
CPUs are Durons

             reply	other threads:[~2003-08-02 19:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-02 19:45 Carsten Otto [this message]
2003-08-02 20:57 ` e1000 statistics timer Zwane Mwaikambo
2003-08-02 23:14 ` Marc-Christian Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).