From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752379AbdGECgi (ORCPT <rfc822;w@1wt.eu>);
        Tue, 4 Jul 2017 22:36:38 -0400
Received: from mail-oi0-f65.google.com ([209.85.218.65]:35839 "EHLO
        mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752285AbdGECgh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Jul 2017 22:36:37 -0400
Date: Tue, 04 Jul 2017 19:36:32 -0700
User-Agent: K-9 Mail for Android
In-Reply-To: <20170704233219.18790-1-afaerber@suse.de>
References: <DC4E6E803E914F4B8AFE57F1456019F10364478E@srv-mail-02.actions.com.cn> <20170704233219.18790-1-afaerber@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Subject: Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot()
To: linux-arm-kernel@lists.infradead.org,
        =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
CC: support@lemaker.org,
        =?UTF-8?B?5byg5aSp55uK?= <tyzhang@actions-semi.com>,
        Arnd Bergmann <arnd@arndb.de>,
        =?UTF-8?B?5qKF5Yip?= <harrymei@actions-semi.com>,
        linux-kernel@vger.kernel.org,
        Thomas Liau <thomas.liau@actions-semi.com>,
        Russell King <linux@armlinux.org.uk>, support@cubietech.com,
        lee@cubietech.com, =?UTF-8?B?5byg5Lic6aOO?= <zhangdf@actions-semi.com>,
        =?UTF-8?B?5YiY54Kc?= <liuwei@actions-semi.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <3F3740FC-3873-4C01-A625-C8DC7F50A018@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v652ahV6029796

On July 4, 2017 4:32:18 PM PDT, "Andreas Färber" <afaerber@suse.de> wrote:
>Commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45 ("ARM: owl: smp: Drop
>bogus holding pen") simplified the S500 SMP code by removing a loop for
>pen_release in owl_secondary_boot(). Since then it is only calling
>owl_v7_invalidate_l1() before branching to secondary_startup().
>
>The owl_v7_invalidate_l1() assembler function is superfluous, too.
>Therefore drop owl_secondary_boot() and use secondary_boot() directly.
>
>Cc: David Liu <liuwei@actions-semi.com>
>Signed-off-by: Andreas Färber <afaerber@suse.de>
>---

>-	writel(virt_to_phys(owl_secondary_startup),
>+	writel(virt_to_phys(secondary_startup),
> 	       timer_base_addr + OWL_CPU1_ADDR + (cpu - 1) * 4);

This is a kernel symbol so please use __pa_symbol() here, also you might want to build with CONFIG_DEBUG_VIRTUAL and see if you get other warnings about using virt_to_phys() in the owl platform code (I did not check if there are other uses)

-- 
Florian