From: Florent Coste <coste.florent@free.fr>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: Re 2.6.0-test2-mm4 (pppd problem)
Date: Tue, 12 Aug 2003 20:07:17 +0200 [thread overview]
Message-ID: <3F392CD5.3080400@free.fr> (raw)
In-Reply-To: <3F334304.9070502@free.fr>
Andrew Morton wrote:
>
>> Florent Coste <coste.florent@free.fr> wrote:
>>
>>
>>> - test2-mm2 : pppd starts ok (i use & follow 2.5.x & 2.6-test
>>> branch since ~2.5.40 .... 2.5.72-mm2 was ok for instance)
>>> - test2-mm3-1 : pppd does not start, kobject badness trace, full
>>> traces in my last email and parts above :
>>>
>>
>>
>> The `badness' thing is just telling us that netdevices aren't fully
>> up to
>> speed with the kobject layer yet. Don't worry about that.
>>
>> As for the ppp problem: don't know, sorry. There was a small change
>> in ppp
>> between those two kernel versions, so it would be useful if you could
>> do a
>> `patch -R' of the below, see if that fixes mm3-1. Thanks.
>
Andrew,
Sorry for the late reply :
I made the patch -R of ppp stuf against mm3-1 : same result as with the
patch.
I thought making a strace -f pppd of both a working kernel (test2-mm2)
and the first non working
(test2-mm3-1) can be usefull, strace result files are available at
http://coste.florent.free.fr
(pid of mm3 have been changed to match the ones of mm2 so that the diff
is easy to read).
I also made the same test with test2-mm4 : same result as mm3-1. I'll
test 2.6.0-test3(-mm1) soon
Great Regards,
Florent
>>
>> diff -Nru a/drivers/char/tty_io.c b/drivers/char/tty_io.c
>> --- a/drivers/char/tty_io.c Wed Aug 6 14:30:49 2003
>> +++ b/drivers/char/tty_io.c Wed Aug 6 14:30:49 2003
>> @@ -611,6 +611,8 @@
>> (tty->driver->stop)(tty);
>> }
>>
>> +EXPORT_SYMBOL(stop_tty);
>> +
>> void start_tty(struct tty_struct *tty)
>> {
>> if (!tty->stopped || tty->flow_stopped)
>> @@ -628,6 +630,8 @@
>> (tty->ldisc.write_wakeup)(tty);
>> wake_up_interruptible(&tty->write_wait);
>> }
>> +
>> +EXPORT_SYMBOL(start_tty);
>>
>> static ssize_t tty_read(struct file * file, char * buf, size_t count,
>> loff_t *ppos)
>> diff -Nru a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c
>> --- a/drivers/net/ppp_async.c Wed Aug 6 14:30:49 2003
>> +++ b/drivers/net/ppp_async.c Wed Aug 6 14:30:49 2003
>> @@ -891,6 +891,11 @@
>> process_input_packet(ap);
>> } else if (c == PPP_ESCAPE) {
>> ap->state |= SC_ESCAPE;
>> + } else if (I_IXON(ap->tty)) {
>> + if (c == START_CHAR(ap->tty))
>> + start_tty(ap->tty);
>> + else if (c == STOP_CHAR(ap->tty))
>> + stop_tty(ap->tty);
>> }
>> /* otherwise it's a char in the recv ACCM */
>> ++n;
>>
>>
>>
>>
>>
>
>
>
>
prev parent reply other threads:[~2003-08-12 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-05 1:56 Re 2.6.0-test2-mm4 Florent Coste
2003-08-05 5:57 ` Andrew Morton
2003-08-06 21:18 ` Florent Coste
2003-08-06 21:32 ` Andrew Morton
[not found] ` <3F334304.9070502@free.fr>
2003-08-12 18:07 ` Florent Coste [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F392CD5.3080400@free.fr \
--to=coste.florent@free.fr \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).