From: Tommy Christensen <tommy.christensen@tpack.net>
To: kuznet@ms2.inr.ac.ru
Cc: Linus Torvalds <torvalds@osdl.org>,
akpm@osdl.org, Andries.Brouwer@cwi.nl,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@oss.sgi.com, "David S. Miller" <davem@redhat.com>
Subject: Re: Linux 2.6.0-test9
Date: Tue, 28 Oct 2003 01:42:39 +0100 [thread overview]
Message-ID: <3F9DBB7F.7030309@tpack.net> (raw)
In-Reply-To: 200310271936.WAA07348@yakov.inr.ac.ru
kuznet@ms2.inr.ac.ru wrote:
> Hello!
>
>
>>And Alexey apparently tried to do the "FIXME" part, but without thinking
>>about the SIGURG part.
>
>
> Actually, it was thought a lot for several linux-2.x. :-)
>
>
>
>>We _need_ to stop at urgent data and we _should_ return -EINTR, and let
>>the SIGURG handler do the URG read. Otherwise we'll lose urgent data (or
>>we'll just read it inline without realizing that it was urgent data).
>
>
> The patch was expected not to break this property. Alas, something
> is overlooked yet. I still do not understand what exactly is broken,
> I feel I have to find some rlogin to experiment in vivo.
Hi Alexey
I think the patch breaks things because it consumes (or rather skips)
the urgent data ( in the code after the label found_ok_skb: ).
Since this happens before the SIGURG handler is run, it won't find
any urgent data.
What do you think?
The patch by Linus seems to be fine though.
-Tommy
next prev parent reply other threads:[~2003-10-28 0:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-26 19:40 Linux 2.6.0-test9 Andries.Brouwer
2003-10-27 0:01 ` Andrew Morton
2003-10-27 0:21 ` Linus Torvalds
2003-10-27 0:28 ` Linus Torvalds
2003-10-27 6:43 ` David S. Miller
2003-10-27 19:54 ` kuznet
2003-10-27 19:36 ` kuznet
2003-10-28 0:42 ` Tommy Christensen [this message]
2003-10-28 18:25 ` kuznet
-- strict thread matches above, loose matches on Subject: below --
2003-10-27 10:58 Andries.Brouwer
2003-10-27 9:47 Mikael Pettersson
2003-10-27 1:48 Andries.Brouwer
2003-10-27 2:10 ` Linus Torvalds
2003-10-27 9:40 ` David S. Miller
2003-10-26 18:51 P. Christeas
2003-10-27 3:16 ` Andrew Morton
2003-10-26 15:32 Shane Shrybman
2003-10-26 16:27 ` Marco Roeland
2003-10-26 11:08 Andries.Brouwer
2003-10-26 13:57 ` OGAWA Hirofumi
2003-10-26 10:59 Andries.Brouwer
2003-10-27 23:37 ` bill davidsen
2003-10-26 10:26 Andries.Brouwer
2003-10-26 1:16 Andries.Brouwer
2003-10-26 3:12 ` OGAWA Hirofumi
2003-10-26 5:48 ` Linus Torvalds
2003-10-27 23:26 ` bill davidsen
2003-10-30 9:20 ` Russell King
2003-10-30 16:44 ` Bill Davidsen
2003-10-30 17:23 ` John Bradford
2003-10-25 19:09 Linus Torvalds
2003-10-25 19:52 ` Marcelo Tosatti
2003-10-25 20:14 ` viro
2003-10-25 22:35 ` Linus Torvalds
2003-10-25 23:45 ` Jose Luis Domingo Lopez
2003-10-26 12:05 ` Patrik Wallstrom
2003-10-27 18:21 ` Patrik Wallstrom
2003-10-27 22:51 ` bill davidsen
2003-10-28 2:12 ` Jeff Garzik
2003-10-28 4:52 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F9DBB7F.7030309@tpack.net \
--to=tommy.christensen@tpack.net \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).