From: "Timo Kamph" <timo@kamph.org>
To: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6]: IPv4: strcpy -> strlcpy
Date: Thu, 27 Nov 2003 21:48:24 +0100 [thread overview]
Message-ID: <3FC67128.14704.30155D53@localhost> (raw)
In-Reply-To: <1069946737.10246.1.camel@glass.felipe-alfaro.com>
On 27 Nov 2003 at 16:25, Felipe Alfaro Solana wrote:
> --- linux-2.6.0-test11.orig/net/ipv4/netfilter/ipchains_core.c 2003-11-26 21:45:26.000000000 +0100
> +++ linux-2.6.0-test11/net/ipv4/netfilter/ipchains_core.c 2003-11-27 13:28:39.884442527 +0100
> @@ -1173,7 +1173,7 @@
> = kmalloc(SIZEOF_STRUCT_IP_CHAIN, GFP_KERNEL);
> if (label == NULL)
> panic("Can't kmalloc for firewall chains.\n");
> - strcpy(label->label,name);
> + strlcpy(label->label, name, sizeof(label->name));
^^^^^^
I guess this shoud be label->label, or am I wrong?
Timo
next prev parent reply other threads:[~2003-11-27 20:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-27 14:04 [PATCH 2.6]: IPv4: strcpy -> strlcpy Felipe Alfaro Solana
2003-11-27 14:21 ` David Roundy
2003-11-27 15:25 ` Felipe Alfaro Solana
2003-11-27 20:48 ` Timo Kamph [this message]
2003-11-27 22:09 ` Felipe Alfaro Solana
2003-11-28 2:05 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 9:42 ` David Woodhouse
2003-11-30 10:26 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FC67128.14704.30155D53@localhost \
--to=timo@kamph.org \
--cc=felipe_alfaro@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).