linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "Prakash K. Cheemplavam" <prakashpublic@gmx.de>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: libata and pm
Date: Sun, 30 Nov 2003 12:02:33 -0500	[thread overview]
Message-ID: <3FCA22A9.2050805@pobox.com> (raw)
In-Reply-To: <3FCA2153.1040900@gmx.de>

Prakash K. Cheemplavam wrote:
> Jeff Garzik wrote:
> 
>> Prakash K. Cheemplavam wrote:
>>
>>> Hi,
>>>
>>> I wonder whether libata can easily be made compatible with swsup or 
>>> pmdisk.
>>>
>>> Currently my tries stop with the message:
>>>
>>> PM: Preparing system for suspend
>>> Stopping tasks: 
>>> =================================================exiting...========
>>>  stopping tasks failed (1 tasks remaining)
>>> Restarting tasks...<6> Strange, katad-1 not stopped
>>>  done
>>>
>>>
>>> I think that katad belongs to libata.
>>
>>
>>
>> I'm curious if this [completely untested] patch works?  :)
> 
> 
> Well, it works as it should -I guess-,ie. swsusp proceeds, but (as 
> expected) after all it doesn't work with scsi and swsusp gives a kernel 
> panic. But that is another matter. ;-)
> 
> Nevertheless I got following wanrings on compile (second one was already 
> there):
> 
> drivers/scsi/libata-core.c: In function `ata_thread':
> drivers/scsi/libata-core.c:2571: Warnung: implicit declaration of 
> function `refrigerator'
> drivers/scsi/libata-core.c: At top level:
> drivers/scsi/libata-core.c:2141: Warnung: `ata_qc_push' defined but not 
> used
> 
> (Furthermore the patch didn't want to apply, so I had to do it by hand.)


Duh, I'm silly... you need #include <linux/suspend.h> at the top of that 
file, too.  I'm amazed swsusp proceeds at all :)

	Jeff




      reply	other threads:[~2003-11-30 17:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-30 10:51 libata and pm Prakash K. Cheemplavam
2003-11-30 16:02 ` Jeff Garzik
2003-11-30 16:56   ` Prakash K. Cheemplavam
2003-11-30 17:02     ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FCA22A9.2050805@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prakashpublic@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).