From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264957AbTK3RtJ (ORCPT ); Sun, 30 Nov 2003 12:49:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264959AbTK3RtJ (ORCPT ); Sun, 30 Nov 2003 12:49:09 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:11188 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S264957AbTK3RtF (ORCPT ); Sun, 30 Nov 2003 12:49:05 -0500 Message-ID: <3FCA2D82.3040606@pobox.com> Date: Sun, 30 Nov 2003 12:48:50 -0500 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jens Axboe CC: Bartlomiej Zolnierkiewicz , "Prakash K. Cheemplavam" , marcush@onlinehome.de, linux-kernel@vger.kernel.org, eric_mudama@Maxtor.com Subject: Re: Silicon Image 3112A SATA trouble References: <3FC36057.40108@gmx.de> <3FCA1DD3.70004@pobox.com> <20031130165146.GY10679@suse.de> <200311301758.53885.bzolnier@elka.pw.edu.pl> <3FCA2380.1050902@pobox.com> <20031130171006.GA10679@suse.de> <3FCA275B.1080904@pobox.com> <20031130173127.GB6454@suse.de> In-Reply-To: <20031130173127.GB6454@suse.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jens Axboe wrote: > On Sun, Nov 30 2003, Jeff Garzik wrote: > >>Jens Axboe wrote: >> >>>>Well, the constraint we must satisfy is >>>> >>>> sector_count % 15 != 1 >>> >>> >>> (sector_count % 15 != 1) && (sector_count != 1) >>> >>>to be more precise :) >> >> >>Thanks for the clarification, I did not know that. >> >>Avoiding sector_count==1 requires additional code :( Valid requests >>might be a single sector. With page-based blkdevs requests smaller than >>a page would certainly be infrequent, but are still possible, with bsg >>for example... > > > You misread it... sector_count == 1 is fine, sector_count % 15 == 1 is > ok when sector_count is 1 (it would have to be, or sector_count == 1 > would not be ok :) Ahh, duh. Thanks again. Yeah, it makes sense since the bug arises from too-large Serial ATA data transactions on the SATA bus... Jeff