From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A63FCA9EB7 for ; Mon, 21 Oct 2019 17:08:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D49BD2064B for ; Mon, 21 Oct 2019 17:08:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="MCpa+9rR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728437AbfJURIH (ORCPT ); Mon, 21 Oct 2019 13:08:07 -0400 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.84]:32198 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbfJURIH (ORCPT ); Mon, 21 Oct 2019 13:08:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1571677682; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=g5fftcy+sbjcXJkucAV/OZbKo+UWi5WQTkrvCV2Jtos=; b=MCpa+9rRKrdom/xaOpun1m6gqtX0goa1UYwlgcdk+bUa7vOK5N5D/I6Gpd2icxGPFb VPW3wd2o3OPlb6EII1dFDERgH46BzQRrXeWmsg5QSFUpNQBjNKt7p27ys1l/c/xfPDjy GxudTskSRd6qrn2lWgpMdDF68/6tGAGD14y3tLP1f7rhGJIFtUIBMP90yQOwuo/RAjij OoQz2iiSsyt+2CDiNGYpMCWOcJtyHk0fQWQu4AU2wcNPtw5QMhnJINkwqlmfViY8G7hJ lXufkL/Pu1Wyg+TvB99AN5V6UAt1m6bCwmifRDuBiqREsTYbwtmOBOpxS+0tTQ2ByCuk QE9w== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Qpw97WFDVCbXA4Ewxc=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 44.28.1 DYNA|AUTH) with ESMTPSA id R0b2a8v9LH7VLxq (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 21 Oct 2019 19:07:31 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v2 07/11] omap: remove old hsmmc.[ch] and in Makefile From: "H. Nikolaus Schaller" In-Reply-To: <20191021143008.GS5610@atomide.com> Date: Mon, 21 Oct 2019 19:07:31 +0200 Cc: =?utf-8?Q?Beno=C3=AEt_Cousson?= , Rob Herring , Mark Rutland , Russell King , Ulf Hansson , Kalle Valo , Mike Rapoport , David Sterba , "Rafael J. Wysocki" , Petr Mladek , Sakari Ailus , Kefeng Wang , Yangtao Li , Alexios Zavras , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , John Stultz , Bjorn Helgaas , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Content-Transfer-Encoding: 7bit Message-Id: <3FDBE28F-B2C5-4EDE-905C-687F601462B6@goldelico.com> References: <9bd4c0bb0df26523d7f5265cdb06d86d63dafba8.1571510481.git.hns@goldelico.com> <20191021143008.GS5610@atomide.com> To: Tony Lindgren X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 21.10.2019 um 16:30 schrieb Tony Lindgren : > > * H. Nikolaus Schaller [191019 18:43]: >> --- a/arch/arm/mach-omap2/Makefile >> +++ b/arch/arm/mach-omap2/Makefile >> @@ -216,7 +216,6 @@ obj-$(CONFIG_MACH_NOKIA_N8X0) += board-n8x0.o >> >> # Platform specific device init code >> >> -omap-hsmmc-$(CONFIG_MMC_OMAP_HS) := hsmmc.o >> obj-y += $(omap-hsmmc-m) $(omap-hsmmc-y) > > The related obj-y line can go now too, right? Yes, I think so. It is a construction that I have never seen before :) Therefore I did not recognize that it is related. > And looks like common.h also has struct omap2_hsmmc_info > so maybe check by grepping for hsmmc_info to see it's gone. Yes, it is just a forward-declaration of the struct name with no user anywhere. Scheduled for v3. BTW: should this series go through your tree since it is an omap machine? BR and thanks, Nikolaus