From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CA6C433EF for ; Tue, 1 Mar 2022 17:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236700AbiCARzF (ORCPT ); Tue, 1 Mar 2022 12:55:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231542AbiCARzE (ORCPT ); Tue, 1 Mar 2022 12:55:04 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55D7832ED0; Tue, 1 Mar 2022 09:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646157262; x=1677693262; h=message-id:date:mime-version:to:cc:references:from: subject:in-reply-to:content-transfer-encoding; bh=UWQCpVl9cqkY19Vah5HEIK0fbarDiE8S3ggwC/mbwts=; b=EgCJoAv1c6HpK/AHFAMleFbGQGHoJJyFkLf0BoqUs9KB1QKpyOugPIvn APoZ7l++iXYkx9uEcsyWgR6IHgBCJVISQtmM2NLIe+wrAiwWmKj6mLdIc YUa/646y3rJcLd0M2kN+Yey8DqLTUNKhBzN67K8AA58F7wV3slQT3Zxw0 /oGbVkH2fU0fwuIBkourucz1b796JNQCAkr9+ovCZeQ2FxnSUGxvFT0q+ BxEiO+s5PeCFzjSupI3Gp5MLq2NjS3TDzisTOmwlqCKrEcDwK8TsWANZC sXgQweKXrFsJHoZq4trqC+MBUowo8+klB+jJBKYrHoMG823NnMDkg95Xp A==; X-IronPort-AV: E=McAfee;i="6200,9189,10273"; a="277865996" X-IronPort-AV: E=Sophos;i="5.90,146,1643702400"; d="scan'208";a="277865996" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 09:54:21 -0800 X-IronPort-AV: E=Sophos;i="5.90,146,1643702400"; d="scan'208";a="550828073" Received: from fpadash-mobl.amr.corp.intel.com (HELO [10.251.24.56]) ([10.251.24.56]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 09:54:20 -0800 Message-ID: <3a083b4d-9645-dec6-8cdc-481429dd0a1f@intel.com> Date: Tue, 1 Mar 2022 09:54:14 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Jarkko Sakkinen , linux-sgx@vger.kernel.org Cc: Dave Hansen , stable@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Sean Christopherson , Jethro Beekman , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" References: <20220301125836.3430-1-jarkko@kernel.org> From: Dave Hansen Subject: Re: [PATCH v5] x86/sgx: Free backing memory after faulting the enclave page In-Reply-To: <20220301125836.3430-1-jarkko@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/1/22 04:58, Jarkko Sakkinen wrote: > @@ -32,14 +58,16 @@ static int __sgx_encl_eldu(struct sgx_encl_page *encl_page, > else > page_index = PFN_DOWN(encl->size); > > + page_pcmd_off = sgx_encl_get_backing_page_pcmd_offset(encl, page_index); > + > ret = sgx_encl_lookup_backing(encl, page_index, &b); > if (ret) > return ret; What tree is this against? It looks like it might be on top of Kristen's overcommit series. It would be best if you could test this on top of tip/sgx. Kristen changed code in this area as well.