From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B167C2D0A8 for ; Tue, 29 Sep 2020 01:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1222D20774 for ; Tue, 29 Sep 2020 01:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727722AbgI2BiC (ORCPT ); Mon, 28 Sep 2020 21:38:02 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:45960 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727288AbgI2Bh7 (ORCPT ); Mon, 28 Sep 2020 21:37:59 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 12EF7EE1E3DDF35918F3; Tue, 29 Sep 2020 09:37:58 +0800 (CST) Received: from [10.174.179.62] (10.174.179.62) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Tue, 29 Sep 2020 09:37:48 +0800 Subject: Re: [PATCH] iommu/qcom: add missing put_device() call in qcom_iommu_of_xlate() To: Will Deacon , kernel test robot CC: , , , , , , , , References: <20200918011357.909335-1-yukuai3@huawei.com> <202009220340.bJfsaeQn%lkp@intel.com> <20200921204556.GB3811@willie-the-truck> <20200928230835.GA12939@willie-the-truck> From: "yukuai (C)" Message-ID: <3a2d2c51-dd4f-8384-805a-c91413ce4373@huawei.com> Date: Tue, 29 Sep 2020 09:37:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200928230835.GA12939@willie-the-truck> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.62] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/09/29 7:08, Will Deacon wrote: > On Mon, Sep 21, 2020 at 09:45:57PM +0100, Will Deacon wrote: >> On Tue, Sep 22, 2020 at 03:13:53AM +0800, kernel test robot wrote: >>> Thank you for the patch! Perhaps something to improve: >>> >>> [auto build test WARNING on iommu/next] >>> [also build test WARNING on linus/master v5.9-rc6 next-20200921] >>> [cannot apply to robclark/msm-next] >>> [If your patch is applied to the wrong git tree, kindly drop us a note. >>> And when submitting patch, we suggest to use '--base' as documented in >>> https://git-scm.com/docs/git-format-patch] >>> >>> url: https://github.com/0day-ci/linux/commits/Yu-Kuai/iommu-qcom-add-missing-put_device-call-in-qcom_iommu_of_xlate/20200918-091341 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next >>> config: arm64-randconfig-r023-20200920 (attached as .config) >>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4e8c028158b56d9c2142a62464e8e0686bde3584) >>> reproduce (this is a W=1 build): >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # install arm64 cross compiling tool for clang build >>> # apt-get install binutils-aarch64-linux-gnu >>> # save the attached .config to linux build tree >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >>> >>> All warnings (new ones prefixed by >>): >>> >>>>> drivers/iommu/arm/arm-smmu/qcom_iommu.c:601:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] >>> return -EINVAL; >>> ^ >>> drivers/iommu/arm/arm-smmu/qcom_iommu.c:599:3: note: previous statement is here >>> if (WARN_ON(qcom_iommu != dev_iommu_priv_get(dev))) >> >> Oh, this looks like a nasty bug. Seems we're missing some braces. > > Yu Kuai: please could you send a v2 of this? > Hi, Will Thanks for your notice, will send a V2 soon. Yu Kuai