From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@codeaurora.org>, Ryder Lee <ryder.lee@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Roy Luo <royluo@google.com>, YF Luo <yf.luo@mediatek.com>,
Yiwei Chung <yiwei.chung@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mt76: fix checkpatch warnings and errors
Date: Sun, 21 Jul 2019 09:56:18 -0700 [thread overview]
Message-ID: <3a2d6eb86fc211002607aad12b35648736e46342.camel@perches.com> (raw)
In-Reply-To: <87blxnsmxm.fsf@purkki.adurom.net>
On Sun, 2019-07-21 at 13:26 +0300, Kalle Valo wrote:
> Ryder Lee <ryder.lee@mediatek.com> writes:
> > Fix warnings and errors as much as possible.
[]
> This is way too big and the commit log is too vague, please fix one
> problem at a time and describe in the commit log what you fixed.
Hello Ryder.
One option is to perform all the whitespace corrections
in a single patch and then show that the object files
have not changed.
I posted a trivial script several years ago that might
be of some help here.
https://lore.kernel.org/lkml/1405128087.6751.12.camel@joe-AO725/
It trivially reformats using checkpatch and produces a
possible set of changes that can be used to update a
git tree.
prev parent reply other threads:[~2019-07-21 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 6:55 [PATCH 1/3] mt76: fix checkpatch warnings and errors Ryder Lee
2019-07-19 6:55 ` [PATCH 2/3] mt76: mt7615: add 4 WMM sets support Ryder Lee
[not found] ` <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ@mail.gmail.com>
2019-07-19 7:27 ` Ryder Lee
2019-07-19 6:55 ` [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values Ryder Lee
2019-07-19 10:17 ` Ryder Lee
2019-07-21 10:28 ` Kalle Valo
2019-07-21 10:26 ` [PATCH 1/3] mt76: fix checkpatch warnings and errors Kalle Valo
2019-07-21 16:56 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a2d6eb86fc211002607aad12b35648736e46342.camel@perches.com \
--to=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=yf.luo@mediatek.com \
--cc=yiwei.chung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).