From: Si-Wei Liu <si-wei.liu@oracle.com>
To: mst <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
Parav Pandit <parav@nvidia.com>
Cc: Eli Cohen <elic@nvidia.com>,
Wu Zongyong <wuzongyong@linux.alibaba.com>,
virtualization <virtualization@lists.linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
eperezma <eperezma@redhat.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
Gautam Dawar <gdawar@xilinx.com>, Cindy Lu <lulu@redhat.com>,
Yongji Xie <xieyongji@bytedance.com>
Subject: Re: [PATCH V2 2/3] vdpa_sim_net: support feature provisioning
Date: Mon, 10 Oct 2022 10:44:02 -0700 [thread overview]
Message-ID: <3a43d0c6-1537-8396-1b7b-68cc24f50c18@oracle.com> (raw)
In-Reply-To: <CACGkMEsvnE6Kuvmd+5gh=mQfb57DQYnJEWegXVVO+6pWs=KY3g@mail.gmail.com>
Hi Michael,
Noticed that you just merged this series that we now got two nominally
duplicated attributes: VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES and
VDPA_ATTR_DEV_FEATURES. I think Jason agreed to remove one of them but
did not get chance to post a new series to catch up with the merge
window. Do you mind if I post a format patch similar as below to rectify
this quickly from linux-next, without unnecessarily getting the dup
exposed to the uAPI?
Thanks,
-Siwei
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -855,7 +855,7 @@ static int vdpa_dev_net_config_fill(struct
vdpa_device *vdev, struct sk_buff *ms
features_device = vdev->config->get_device_features(vdev);
- if (nla_put_u64_64bit(msg,
VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, features_device,
+ if (nla_put_u64_64bit(msg, VDPA_ATTR_DEV_FEATURES, features_device,
VDPA_ATTR_PAD))
return -EMSGSIZE;
diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h
index 9bd7923..6e620c3 100644
--- a/include/uapi/linux/vdpa.h
+++ b/include/uapi/linux/vdpa.h
@@ -53,10 +53,8 @@ enum vdpa_attr {
VDPA_ATTR_DEV_VENDOR_ATTR_NAME, /* string */
VDPA_ATTR_DEV_VENDOR_ATTR_VALUE, /* u64 */
- VDPA_ATTR_DEV_FEATURES, /* u64 */
-
/* virtio features that are supported by the vDPA device */
- VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, /* u64 */
+ VDPA_ATTR_DEV_FEATURES, /* u64 */
/* new attributes must be added above here */
VDPA_ATTR_MAX,
On 9/28/2022 9:10 PM, Jason Wang wrote:
> I think VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES and
> VDPA_ATTR_DEV_FEATURES are equivalent, we can rebase on each other if
> it is needed.
>
> Thanks
>
>
next prev parent reply other threads:[~2022-10-10 17:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 2:43 [PATCH V2 0/3] vdpa: device feature provisioning Jason Wang
2022-09-22 2:43 ` [PATCH V2 1/3] " Jason Wang
2022-09-22 2:43 ` [PATCH V2 2/3] vdpa_sim_net: support " Jason Wang
2022-09-22 5:13 ` Eli Cohen
2022-09-22 7:29 ` Michael S. Tsirkin
2022-09-22 7:47 ` Eli Cohen
2022-09-22 7:53 ` Michael S. Tsirkin
2022-09-22 8:01 ` Eli Cohen
2022-09-22 9:11 ` Michael S. Tsirkin
2022-09-23 4:17 ` Jason Wang
2022-09-23 4:20 ` Jason Wang
2022-09-22 9:22 ` Stefano Garzarella
2022-09-23 3:33 ` Jason Wang
2022-09-23 20:01 ` Si-Wei Liu
2022-09-26 7:11 ` Jason Wang
2022-09-26 7:11 ` Jason Wang
[not found] ` <afe960d3-730a-b52c-e084-40bf080b27fa@oracle.com>
2022-09-27 3:59 ` Jason Wang
2022-09-27 4:07 ` Jason Wang
[not found] ` <7c555830-6909-d482-ea05-4316a02012df@oracle.com>
2022-09-29 4:10 ` Jason Wang
2022-10-10 17:44 ` Si-Wei Liu [this message]
[not found] ` <c5a96de5-699a-8b5e-0e89-bfe1822e1105@oracle.com>
2022-09-29 4:55 ` Jason Wang
2022-10-07 0:35 ` Si-Wei Liu
2022-10-13 7:10 ` Jason Wang
[not found] ` <e613a51c-c8c3-1021-6ac8-8ca485f4a9a5@oracle.com>
2022-10-18 7:45 ` Jason Wang
2022-09-22 2:43 ` [PATCH V2 3/3] vp_vdpa: " Jason Wang
2022-09-23 20:11 ` Si-Wei Liu
2022-09-26 7:14 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a43d0c6-1537-8396-1b7b-68cc24f50c18@oracle.com \
--to=si-wei.liu@oracle.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzongyong@linux.alibaba.com \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).