From: Qi Zheng <zhengqi.arch@bytedance.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>, Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the driver-core tree
Date: Mon, 20 Feb 2023 18:15:33 +0800 [thread overview]
Message-ID: <3a449abe-b5c8-cee3-6c2e-bfb79eb51f73@bytedance.com> (raw)
In-Reply-To: <Y/NCPC3rjOT7dJtE@debian.me>
On 2023/2/20 17:49, Bagas Sanjaya wrote:
> On Mon, Feb 20, 2023 at 08:31:58AM +0100, Greg KH wrote:
>> On Mon, Feb 20, 2023 at 03:26:41PM +0800, Qi Zheng wrote:
>>>
>>>
>>> On 2023/2/20 13:31, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> After merging the driver-core tree, today's linux-next build
>>>> (htmldocs) produced this warning:
>>>>
>>>> Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.
>>>>
>>>> Introduced by commit
>>>>
>>>> d3002468cb5d ("debugfs: update comment of debugfs_rename()")
>>>
>>> This is just a comment modification. Didn't see where my modification
>>> caused this WARNING. :(
>>
>> Yeah, I don't understand either, here's the diff, what's wrong with it?
>>
>>
>> --- a/fs/debugfs/inode.c
>> +++ b/fs/debugfs/inode.c
>> @@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
>> * exist for rename to succeed.
>> *
>> * This function will return a pointer to old_dentry (which is updated to
>> - * reflect renaming) if it succeeds. If an error occurs, %NULL will be
>> - * returned.
>> + * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
>> + * will be returned.
>> *
>> * If debugfs is not enabled in the kernel, the value -%ENODEV will be
>> * returned.
>
> Hi Greg and Qi,
>
> The simple fix is to drop the percent (which is an inline code variant):
>
> ---- >8 ----
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 58a35afb7c5d89..a7a6a0821605a8 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
> * exist for rename to succeed.
> *
> * This function will return a pointer to old_dentry (which is updated to
> - * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
> + * reflect renaming) if it succeeds. If an error occurs, ERR_PTR(-ERROR)
> * will be returned.
> *
> * If debugfs is not enabled in the kernel, the value -%ENODEV will be
LGTM, do I need to resend the patch with this fix?
>
> Thanks.
>
--
Thanks,
Qi
next prev parent reply other threads:[~2023-02-20 10:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 5:31 linux-next: build warning after merge of the driver-core tree Stephen Rothwell
2023-02-20 7:26 ` Qi Zheng
2023-02-20 7:31 ` Greg KH
2023-02-20 9:49 ` Bagas Sanjaya
2023-02-20 10:15 ` Qi Zheng [this message]
2023-02-20 10:50 ` Greg KH
2023-02-20 11:01 ` Qi Zheng
-- strict thread matches above, loose matches on Subject: below --
2023-03-27 1:03 Stephen Rothwell
2023-03-27 7:31 ` Greg KH
2022-05-01 22:36 Stephen Rothwell
2021-12-06 8:30 Stephen Rothwell
2021-12-06 12:53 ` Heiko Carstens
2021-12-07 10:23 ` Greg KH
2020-09-09 7:23 Stephen Rothwell
2020-09-09 7:40 ` Greg KH
2019-08-05 3:04 Stephen Rothwell
2019-08-05 4:56 ` Stephen Rothwell
2019-08-06 0:03 ` Saravana Kannan
2019-08-01 5:05 Stephen Rothwell
2019-08-01 6:10 ` Greg KH
2019-07-04 6:24 Stephen Rothwell
2019-07-04 8:21 ` Greg KH
2019-07-04 6:17 Stephen Rothwell
2019-07-04 6:30 ` Greg KH
2015-10-07 4:51 Stephen Rothwell
2015-10-07 6:40 ` Viresh Kumar
2015-10-07 21:48 ` Rafael J. Wysocki
2015-10-07 22:04 ` Stephen Rothwell
2015-10-07 22:47 ` Rafael J. Wysocki
2015-10-08 7:09 ` Viresh Kumar
2015-10-08 20:30 ` Rafael J. Wysocki
2015-10-09 5:36 ` Stephen Rothwell
2015-10-09 6:31 ` Viresh Kumar
2015-10-09 20:49 ` Rafael J. Wysocki
2015-10-09 6:37 ` Viresh Kumar
2013-06-25 8:33 Stephen Rothwell
2013-06-25 12:00 ` Ming Lei
2011-02-21 6:02 Stephen Rothwell
2011-02-21 6:32 ` Greg KH
2011-02-21 20:18 ` Ilya Yanok
2011-02-21 5:37 Stephen Rothwell
2011-02-21 5:50 ` Stephen Rothwell
2011-02-21 6:31 ` Greg KH
2011-03-17 23:10 ` Stephen Rothwell
2010-09-02 3:18 Stephen Rothwell
2010-09-02 3:29 ` Greg KH
2010-09-02 10:14 ` Thomas Renninger
2010-09-02 19:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a449abe-b5c8-cee3-6c2e-bfb79eb51f73@bytedance.com \
--to=zhengqi.arch@bytedance.com \
--cc=bagasdotme@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).