From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C63C433FE for ; Wed, 29 Sep 2021 13:11:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C611F61247 for ; Wed, 29 Sep 2021 13:11:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344073AbhI2NNY (ORCPT ); Wed, 29 Sep 2021 09:13:24 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:53840 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344045AbhI2NNW (ORCPT ); Wed, 29 Sep 2021 09:13:22 -0400 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 503F3405FF for ; Wed, 29 Sep 2021 13:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632921101; bh=JoiXgeyDu/wDtKgvXig0JAW/2J/oGkuZPAkmrTfmVCU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=jXAR1n/X2s3GIC4gnE/l3SOyDz24/MtZvXmeK/SOmYMlYTkxnmxeZ+6unr2FifLEt fyofQj6oBTD2BMIIKITn5dDWR3FV83cNICId3+i+6dZKxdFDdBSNBd+GWUboOSda3C BllOqqrL9WKxRuvBUpHqWUp0SuZXOojVNSM5pQE+khBdldjdHHrcR9paU1RzY3Naw/ E2EdXgLYTAQUyRpITwgJhthSaykO3WwFmEbPuOUxejLZMB59vAhCU//d3SNa5FElXn BnpvLBWnQ04VUNSUfb+fWPkJA53P8m2/40wB0Onh2RBjsrXVYXcwtUpyClwZBndSg0 cOCk3uOQmu8WQ== Received: by mail-lf1-f72.google.com with SMTP id x33-20020a0565123fa100b003fcfd99073dso2367572lfa.6 for ; Wed, 29 Sep 2021 06:11:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JoiXgeyDu/wDtKgvXig0JAW/2J/oGkuZPAkmrTfmVCU=; b=ob5kaaOaUiPQKcAU546BREXleA+utFk0aJoTuuj1J1skNwCbFUOISpnb1e3H/02wQa aoeE7vvYEGYwrZ2fZaZKP87loKHNP1YlNl7Ix9WNSR/6IxNgM5LgB3Ddx7KXDG0PTvCG 76tLZWi+OkhLVsTtk1MGnu/4xWK4N04y/ty5/D5fvfCPADR0sZmGQOASH+QvT3gcKoyw k/Og/XoluXPyzxqm6KCUHxu1bI76VEOqNTmI6s8DeW+sIs0t5SXXe06sSCBGguOMaarQ kMPxLtwIYJUnWwA19R581K5XH+bNTFAG0VxDTzzOJ4BITE/cU0W42USDXUWaLOrKINkp vqlw== X-Gm-Message-State: AOAM5337jxja6CezVGnznNYM9DwVDQhX0P6WEjGKFqJ0C9sqwPSITKT4 f37QPFOjHvTFjxj9AgMAEElszN46lVrIppv/FARb3U2GNVMfgjyVxkrmO0lMHpQAEDvsZRQPgwW Ei4SEcnSoseBi/X5RYaFRBKebZfc6NdAyeVrxonizug== X-Received: by 2002:ac2:46d8:: with SMTP id p24mr11266972lfo.227.1632921100546; Wed, 29 Sep 2021 06:11:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznWesDGlVbpOGXmNoUHyfQm6C1LgrsZRBRFXcHyHVZjVJqCslONob7x8cEIpVteArjBrrBoQ== X-Received: by 2002:ac2:46d8:: with SMTP id p24mr11266954lfo.227.1632921100386; Wed, 29 Sep 2021 06:11:40 -0700 (PDT) Received: from [192.168.0.197] ([193.178.187.25]) by smtp.gmail.com with ESMTPSA id d9sm240427lfl.175.2021.09.29.06.11.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 06:11:39 -0700 (PDT) Subject: Re: [PATCH v2 10/12] soc: samsung: pmu: modularize the Exynos ARMv8 PMU driver To: Will McVicker , Russell King , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Linus Walleij , Alessandro Zummo , Alexandre Belloni , John Stultz , Thomas Gleixner Cc: Lee Jones , Geert Uytterhoeven , Saravana Kannan , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-11-willmcvicker@google.com> From: Krzysztof Kozlowski Message-ID: <3a507f39-5ac7-1b4b-62b2-7c98a76118d7@canonical.com> Date: Wed, 29 Sep 2021 15:11:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210928235635.1348330-11-willmcvicker@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2021 01:56, Will McVicker wrote: > In order to only modularize the Exynos ARMv8 PMU driver, we have to > split it up from the ARM PMU driver. So make the following Kconfig > changes: > * EXYNOS_PMU -> EXYNOS_PMU_ARM64 > * EXYNOS_PMU_ARM_DRIVERS -> EXYNOS_PMU_ARM > > This patch also includes the necessary modularization changes. > > Lastly, have EXYNOS_PMU_ARM64 use "default y if ARCH_EXYNOS && ARM64" > instead of having ARCH_EXYNOS select it directly. The same comments as for clocks patch: 1. You missed to explain the most important change - removed enforcing of built-in. 2. You ignored Geert's comments and broke distros configs for Exynos platforms. Best regards, Krzysztof