From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbdCBNuU (ORCPT ); Thu, 2 Mar 2017 08:50:20 -0500 Received: from mga14.intel.com ([192.55.52.115]:1671 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753133AbdCBNuN (ORCPT ); Thu, 2 Mar 2017 08:50:13 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,231,1484035200"; d="scan'208";a="830135482" Subject: Re: [RESEND PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <01815bce74cdb525f45d4088648b11dcc48da040.1488383202.git.lolivei@synopsys.com> Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Jarkko Nikula Message-ID: <3a84bb00-ab25-e36f-5552-0d4232c60e36@linux.intel.com> Date: Thu, 2 Mar 2017 15:46:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <01815bce74cdb525f45d4088648b11dcc48da040.1488383202.git.lolivei@synopsys.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/17 17:59, Luis Oliveira wrote: > - Definitions were added to core library > - A example was added to designware-core.txt Documentation that shows > how the slave can be setup using DTS > > SLAVE related definitions were added to the core of the controller. > > Signed-off-by: Luis Oliveira > Reviewed-by: Andy Shevchenko > Acked-by: Rob Herring > --- > V5->V6 > - Included an example of use in the device tree binding document > (with the RESEND) > - Removed the i2c-designware.txt binding leading 0 to add the Rob > Herring ack. > > .../devicetree/bindings/i2c/i2c-designware.txt | 16 +++++++++- > drivers/i2c/busses/i2c-designware-core.h | 35 ++++++++++++++++++++-- > 2 files changed, 48 insertions(+), 3 deletions(-) > ... > diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h > index 35d7264d9e3a..b620d76ffc8d 100644 > --- a/drivers/i2c/busses/i2c-designware-core.h > +++ b/drivers/i2c/busses/i2c-designware-core.h > @@ -1,5 +1,5 @@ ... > @@ -196,7 +221,11 @@ > * @acquire_lock: function to acquire a hardware lock on the bus > * @release_lock: function to release a hardware lock on the bus > * @pm_runtime_disabled: true if pm runtime is disabled > - * > + * @dynamic_tar_update_enabled: true if dynamic TAR update is enabled > + * @disable: function to disable the controller > + * @disable_int: function to disable all interrupts > + * @init: function to initialize the I2C hardware > + * @mode: operation mode - I2C slave or I2C master > * HCNT and LCNT parameters can be used if the platform knows more accurate > * values than the one computed based only on the input clock frequency. > * Leave them to be %0 if not used. > @@ -206,6 +235,7 @@ struct dw_i2c_dev { > void __iomem *base; > struct completion cmd_complete; > struct clk *clk; > + struct i2c_client *slave; > u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev); > struct dw_pci_controller *controller; > int cmd_err; > @@ -225,6 +255,7 @@ struct dw_i2c_dev { > struct i2c_adapter adapter; > u32 functionality; > u32 master_cfg; > + u32 slave_cfg; > unsigned int tx_fifo_depth; > unsigned int rx_fifo_depth; > int rx_outstanding; You should add comments for "slave" and "slave_cfg" since they are added here and move comments for other members variables to patches 3/6 and 5/6 where they are added. -- Jarkko