From: German Gomez <german.gomez@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org, James Clark <james.clark@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 1/1] perf arm-spe: report all SPE records as "all" events
Date: Thu, 25 Nov 2021 11:54:16 +0000 [thread overview]
Message-ID: <3a84dd85-7bae-49ea-75cc-52f9a8220cc4@arm.com> (raw)
In-Reply-To: <20211125075358.GA1599216@leoy-ThinkPad-X240s>
Hi Leo,
On 25/11/2021 07:53, Leo Yan wrote:
> On Wed, Nov 17, 2021 at 02:28:32PM +0000, German Gomez wrote:
>> [...]
> After checked the event types, I think "other" samples would include
> below raw event types:
>
> EV_EXCEPTION_GEN
> EV_RETIRED
> EV_NOT_TAKEN
> EV_ALIGNMENT
> EV_PARTIAL_PREDICATE
> EV_EMPTY_PREDICATE
>
> I am just wander if we can use sample.transaction to store these event
> types, otherwise, we cannot distinguish the event type for the samples.
I'm not familiar with the meaning of transactions in this context, but
I agree giving visibility of these remaining events is a good idea. I'm
just unsure where to place them from the available --itrace options.
Regarding the "all" events, we thought having quick access to a global
histogram of all the spe events is useful, and from all the --itrace
options it seemed to fit best under --itrace=o.
Thanks,
German
>
> And it's good fill more sample fields for complete info, like:
>
> sample.addr = record->virt_addr;
> sample.phys_addr = record->phys_addr;
> sample.data_src = data_src;
>
> Thanks,
> Leo
>
>> [...]
next prev parent reply other threads:[~2021-11-25 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:28 [RESEND PATCH 1/1] perf arm-spe: report all SPE records as "all" events German Gomez
2021-11-25 7:53 ` Leo Yan
2021-11-25 10:21 ` James Clark
2021-11-25 12:30 ` Leo Yan
2021-11-25 11:54 ` German Gomez [this message]
2021-11-25 12:49 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a84dd85-7bae-49ea-75cc-52f9a8220cc4@arm.com \
--to=german.gomez@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).